add solution #4977
add solution #4977
Conversation
There was a problem hiding this comment.
Thank you for your hard work! 😊 There are a few critical issues that need to be addressed before we can approve your submission. Specifically, you need to create a separate SCSS file for variables as required by the task, and ensure the background-image URL in stars.scss is relative to index.scss. Additionally, the styles.css file is unnecessary due to the use of the Parcel library. Once these issues are resolved, your solution will be ready for approval. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Great effort on your project! 🎉 While your code is mostly well-structured and organized, there are a few critical issues that need attention to ensure full functionality:
-
Missing
variables.scssFile: It's important to create a separate file for SCSS variables as required by the task. This will help in maintaining and organizing your styles better. -
Incorrect
background-imageURL: Ensure that thebackground-imageURLs in your SCSS files are relative toindex.scss. This will ensure that images load correctly. -
SCSS Compilation: Remember to compile your SCSS into CSS, as browsers cannot interpret SCSS files directly. Make sure the
hrefattribute in your HTML links to the compiled CSS file. -
Unnecessary
styles.cssFile: If you are using Parcel to handle SCSS, thestyles.cssfile might be redundant. Consider removing it to keep your project clean.
These issues are crucial for the functionality of your code, so please address them in future iterations. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <meta | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0" | ||
| /> | ||
| <title>Product cards</title> | ||
| <link | ||
| rel="stylesheet" | ||
| href="./styles/index.scss" | ||
| href="styles/index.scss" |
There was a problem hiding this comment.
The href attribute is pointing to an SCSS file (styles/index.scss). Browsers cannot directly interpret SCSS files. You need to compile your SCSS into a CSS file and link to that CSS file instead.
| // .stars__star | ||
|
|
||
| &__star { | ||
| background-image: url(/src/images/star.svg); |
There was a problem hiding this comment.
The background-image URL should be relative to the index.scss file. Ensure the path is correct so that the image can be loaded properly.
| &__star--3:nth-child(-n + 3), | ||
| &__star--4:nth-child(-n + 4), | ||
| &__star--5 :nth-child(-n + 5) { | ||
| background-image: url(/src/images/star-active.svg); |
There was a problem hiding this comment.
The background-image URL should be relative to the index.scss file. Ensure the path is correct so that the image can be loaded properly.
| // .stars__star | ||
|
|
||
| &__star { | ||
| background-image: url(/src/images/star.svg); |
There was a problem hiding this comment.
The background-image URL should be relative to the index.scss file. Ensure the path is correct so that the image can be loaded properly.
| &__star--3:nth-child(-n + 3), | ||
| &__star--4:nth-child(-n + 4), | ||
| &__star--5 :nth-child(-n + 5) { | ||
| background-image: url(/src/images/star-active.svg); |
There was a problem hiding this comment.
The background-image URL should be relative to the index.scss file. Ensure the path is correct so that the image can be loaded properly.
DEMO LINK