-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bose landing page #2651
base: master
Are you sure you want to change the base?
Bose landing page #2651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hej, looks like a solid amount of work here and thank you for adding a Figma link at the description!
However, I can't find a DEMO link to your work and if I just try to guess and check this one - it's pretty much empty: https://alex-qqren.github.io/layout_miami/
Do you have any deployment problems or have you just overlooked it (taking the amount of work I see here, definitely understandable :) ) ?
Hi Yevhenii Pylypchuk, I have a problem with deploying the site to github. The first commit went through but second commit with the final site show an error while running the command 'npm run deploy'. I had these problems earlier and I deleted the old fork and made this one, but unfortunately after the first commit the problem with deploying the site returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Yevhenii Pylypchuk, I have a problem with deploying the site to github. The first commit went through but second commit with the final site show an error while running the command 'npm run deploy'. I had these problems earlier and I deleted the old fork and made this one, but unfortunately after the first commit the problem with deploying the site returned.
Its because after commits you got updates, you needs to update your fork on gh, and after that make new clone, and add solution here.Can not aprove this because cant see the result,demo link needs to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is my first landing page.
For the site I used:
The layout in Figma can be seen here:
https://www.figma.com/file/DtkQmQ797hk0nI4KfMi2Uq/BOSE-New-Version?type=design&node-id=6703-108&mode=design&t=7xddus74885yl8Vs-0
DEMO LINK: https://alex-qqren.github.io/layout_miami/
Please give me feedback on what I can improve ;]