Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop MyBike #2643

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Develop MyBike #2643

wants to merge 17 commits into from

Conversation

AkifAkhmedov
Copy link

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, here some issues
Remove body margin
image
Make center and bigger font - "Take the streets"
image
Its should in row
image
Here should be 3 bikes in row
image
?
image
make this button smaller
image
Correct width here
image
Contacts and form must be in row
image
Fix this image
image

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. here some problems to fix:
Center your images
image
Your h1 should be in center first screen figma second yours
image
image
fix background image on tables, and h1, also fix it in mobile
image

@yevhenii-pyl
Copy link

MOCKUP:
text_figma

YOUR DEMO:
text_student

Something is off with text here.

@yevhenii-pyl
Copy link

MOCKUP:
header_figma

DEMO:
header_demo

Header positioned wrong.

@yevhenii-pyl
Copy link

MOCKUP:
form_figma

DEMO:
form_demo

Something is off here.

@yevhenii-pyl
Copy link

yevhenii-pyl commented Feb 26, 2024

MOCKUP:
header_mid_mock

DEMO:
header_mid_demo

Image positioned wrong for screen width 744px (same for 320px).

Copy link

@yevhenii-pyl yevhenii-pyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a good job here! 👍
Just a few more adjustments and it's good to go.

Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, things to fix:
Again text positioning
image
again your form, look at mockup
image
Pls, check all pre comments, and fix all things described in them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants