Develop #2636
Open
Develop #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliaklonowska
suggested changes
Feb 13, 2024
asakevych
suggested changes
Mar 11, 2024
| <body class="section"> | ||
| <header class="section__header header" | ||
| id="header"> | ||
| <div class="header-navigation navigation"> |
There was a problem hiding this comment.
if you want navigation to in header block it should have class header__navigation -> due to bem it should be block__element--modifier
Comment on lines
+110
to
+111
| <section class="recommended section__page" | ||
| id="recommended"> |
Comment on lines
+113
to
+115
| <h2 class="title title--secondary"> | ||
| Recommended | ||
| </h2> |
Comment on lines
+119
to
+120
| <img src="./images/picture-1.jpg" class="card__img" | ||
| alt="1"> |
There was a problem hiding this comment.
check formatting, alt should describe what is at image
Comment on lines
+125
to
+127
| <p class="speaker__paragraph"> | ||
| Huge sound anywhere – in the home or outdoors. Beosound A5 is a Wi-Fi and Bluetooth speaker with long-lasting battery and wireless charging built in. | ||
| </p> |
Comment on lines
+47
to
+51
| @mixin laptop() { | ||
| @media (min-width:744px) { | ||
| @content | ||
| } | ||
| } |
| gap: 20px; | ||
|
|
||
| @include laptop { | ||
| grid-template-columns: repeat(6, 80px); |
| gap: 20px; | ||
|
|
||
| @include laptop { | ||
| grid-template-columns: repeat(6, 80px); |
Comment on lines
+40
to
+41
| width: 600px; | ||
| height: 757px; |
There was a problem hiding this comment.
no need to define sizes using px, it's not responsive, by default it will fit content
Comment on lines
+43
to
+46
| &__img { | ||
| height: 600px; | ||
| width: 600px; | ||
| } |
There was a problem hiding this comment.
make image width: 100% and height auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
B&O