This repository has been archived by the owner on May 30, 2019. It is now read-only.
Adding support for a gradle multi-project build #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un-shrinkwrap dev branch for updates.
Remove configuration and script which preventing install on node.js > 0.10.x in preparation for support of node.js 0.12. Closes marklogic-community#683
Update dependencies to latest versions (except marklogic client, to be addressed separately). Fix scss bug revealed by newer SASS compiler, include updated static built files for CSS and browserified module. By updating phantomjs, seems to address the Mac problem of requiring reinstall of PhantomJS (675) TODO: fix e2e testing. Closes marklogic-community#675
selenium start process changed in update to selenium server. Now read URL as a string from promise.
1) element function no longer returns a promise 2) convert e2e promise helpers form Q to bluebird (and remove Q as dependency)
Verify that Firefox 35 e2e testing works with updated version of Selenium. Closes marklogic-community#578
"gulp-tap"ing the files that come out of gulp-sass was rendering a stream which cause event-stream.merge to fail. Tap the inputs to the sass processing and change *their* base, so that the *resulting* stream isn't touched by the tap plugin. It is not known certainly, but this workaround may be necessitated by what is discussed in geejs/gulp-tap#6
Add correct text for tooltips in related tags scenarios. There is a remaining problem, however. For Related Tags popup list, in at least Chrome (but not Firefox), the mouse must: 1. mouseenter the related tags popup area 2. mouseout the related tags popup area 3. go back into the related tags popup area and hover over a link The cause of this isn't known. See marklogic-community#686 Closes marklogic-community#663
When attempting to authenticate user, unset any extant error in the login dialog so that a previous error message doesn't flash at the user while re-authentication is in progress. Closes marklogic-community#654
When the user enters a substring by which to search for tags in the More Tags dialog, format the tags which match the search by making bold the portion of each tag name that matches the search text. Closes marklogic-community#628
…ich allows ML to restart properly on init
Incorporating ml-gradle into Samplestack changes some of the tasks used to configure the database. This is a first attempt to reconcile the changes in the two README.md files accordingly.
At this point it deploys the database and loads data
|
Hi Scott, I was asked to take a look at this PR and verify it. I think it's a great step forward for SampleStack. From a logistical POV, I'm going to recommend we merge #690 first, and then we'll ask for an update to this PR that is cleaner against marklogic/develop branch. |
|
So I'll assign to Scott. Comments on the PR -- I'd recommend moving the gradle wrapper up from the appserver directory to the top. Also, a pass through the README files will be warranted -- I haven't checked that, but suspect some edits or more info will be required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the World Bank, we used a multi-project gradle build. It allows better de-coupling between the database and appserver packages. Let me know what you think.
Scott