Update parser to prepend dialCode on model value #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an update on this PR? We are using the modify version. Would be happy to see it in the main project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I closed PR #75 and am re-submitting. I had originally forked to a company-owned repo which has some extra requirements that cause headaches w/r/t to pull requests. It looked like everyone was on board with these changes, and there are no merge conflicts as of now.
We are using this directive to allow users to input a telephone number, which is then saved to our database. In order for the number to re-display properly, we need to supply the prefix on subsequent page views so the directive will show the proper flag and format the number as expected.
This simple change force-includes the country prefix whenever updating the model value. This behavior could easily be made optional via a config flag.