-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Event
class
#5016
Export Event
class
#5016
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5016 +/- ##
==========================================
- Coverage 89.25% 89.22% -0.03%
==========================================
Files 269 269
Lines 38286 38287 +1
Branches 2347 2339 -8
==========================================
- Hits 34172 34163 -9
- Misses 3117 3138 +21
+ Partials 997 986 -11 ☔ View full report in Codecov by Sentry. |
Can you give a use case where this is needed? |
We create a geocoding control and would like it to fire some events. I think it whouls do it the Maplibre way (extend Class |
I actually though about replacing evented class with eventemmiter library in some point, |
Thanks. eventemitter3 on npm doesn't seem to be actively developed. Maybe browser-native EventTarget. Also nanoevents looks good. In any case I think that extending from even-related class is antipattern. In my case, the |
Yeah, I agree... |
Launch Checklist
Export
Event
class#5015
(already documented)
CHANGELOG.md
under the## main
section.