Change TagsInput onRemove to copy correctly

[ctdunc]

Alright so my last commit introduced a new bug where controlled TagsInputs would not have any callbacks triggered when clicking the x button in a pill.

This commit fixes that issue. I tested it in dash-mantine-components as well, and the behavior is now correct.

[omerchn]

We also encountered this issue. thanks for fixing it.
wouldn't this be more performant? (using only filter instead of splice and then splice)

setValue(_value.filter(_item => _item !== item));

[ctdunc]

We also encountered this issue. thanks for fixing it.
wouldn't this be more performant? (using only filter instead of splice and then splice)

setValue(_value.filter(_item => _item !== item));

No, as this does not work when allowDuplicates is enabled.

The correct solution here is probably toSpliced, but hasnt caught on in terms of browser compatibility

[omerchn]

No, as this does not work when allowDuplicates is enabled.

The correct solution here is probably toSpliced, but hasnt caught on in terms of browser compatibility

Got you. What about:

setValue(_value.filter((_, _index) => _index !== index));

Using splice is prone to cause bugs when used in libraries as it mutates the original array, which is something that consumers of libraries don't expect.
I get that using slice() to create a copy of the array fixes this bug, but it seems more like a hack rather than a correct solutaion.

[ctdunc]

If a maintainer thinks this is worth ill do it. I think its fine as is, signals future use of toSpliced.

Would be good to get some form of this merged though