Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Splitter #12

Merged
merged 62 commits into from
Jan 23, 2024
Merged

Add Splitter #12

merged 62 commits into from
Jan 23, 2024

Conversation

telome
Copy link
Collaborator

@telome telome commented Nov 29, 2023

No description provided.

sunbreak1211
sunbreak1211 reviewed Dec 1, 2023
View reviewed changes
.gitmodules Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 3, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 3, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 3, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 3, 2023
View reviewed changes
deploy/FlapperInit.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 3, 2023
View reviewed changes
deploy/FlapperInit.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 7, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 7, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 7, 2023
View reviewed changes
foundry.toml Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 7, 2023
View reviewed changes
test/FlapperMom.t.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 11, 2023
View reviewed changes
test/Splitter.t.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 13, 2023
View reviewed changes
test/FlapperMom.t.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Dec 13, 2023
View reviewed changes
test/Splitter.t.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 17, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 17, 2023
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Dec 19, 2023
View reviewed changes
deploy/FlapperInit.sol Outdated Show resolved Hide resolved
oldchili
oldchili previously approved these changes Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for merging this implementation.
We might want to discuss moving the rate-limiting to the splitter and supporting burn==0 at some point.

@oldchili
Copy link
Collaborator

Actually we probably want to merge this to splitter first -
#14

sunbreak1211
sunbreak1211 reviewed Jan 19, 2024
View reviewed changes
src/Splitter.sol Outdated Show resolved Hide resolved
telome and others added 2 commits January 19, 2024 13:15
sunbreak1211
sunbreak1211 reviewed Jan 19, 2024
View reviewed changes
src/FlapperUniV2.sol Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Jan 19, 2024
View reviewed changes
src/FlapperUniV2.sol Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Jan 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
oldchili
oldchili reviewed Jan 21, 2024
View reviewed changes
README.md Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Jan 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Jan 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
sunbreak1211
sunbreak1211 reviewed Jan 22, 2024
View reviewed changes
test/Splitter.t.sol Outdated Show resolved Hide resolved
telome and others added 4 commits January 22, 2024 15:59
@telome @sunbreak1211
Update README.md
1bf44a6 
Co-authored-by: sunbreak1211 <[email protected]>
@telome @sunbreak1211
Update README.md
a694cc7 
Co-authored-by: sunbreak1211 <[email protected]>
@telome @sunbreak1211
Update test/FlapperUniV2.t.sol
594b77b 
Co-authored-by: sunbreak1211 <[email protected]>
@telome @sunbreak1211
Update test/Splitter.t.sol
1ba14e7 
Co-authored-by: sunbreak1211 <[email protected]>
sunbreak1211
sunbreak1211 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@sunbreak1211 sunbreak1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oldchili
oldchili approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@oldchili oldchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@telome telome merged commit 4e7a8f4 into dev Jan 23, 2024
2 checks passed
@sunbreak1211 sunbreak1211 deleted the splitter branch April 12, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunbreak1211 sunbreak1211 sunbreak1211 approved these changes

@oldchili oldchili oldchili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@telome @oldchili @sunbreak1211