Fixed NewUref constructor

make-software · Mar 25, 2024 · c021926 · c021926
1 parent 7f7e952
commit c021926
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/tests/types/cl_value/uref_test.go b/tests/types/cl_value/uref_test.go
@@ -28,6 +28,13 @@ func Test_NewURefFromString_toBytes(t *testing.T) {
 	assert.Equal(t, "000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f07", hex.EncodeToString(res.Bytes()))
 }
 
+func Test_NewURefFromString_IncorrectFormat(t *testing.T) {
+	source := "01506f4df2ac64a2233e787c430dc91dad5cee8eabd7d64555f64bdc1a4b4044d7"
+	_, err := key.NewURef(source)
+	require.Error(t, err)
+	assert.Equal(t, err, key.ErrIncorrectPurseFormat)
+}
+
 func Test_FromBytesByType_URef(t *testing.T) {
 	source := "000102030405060708090a0b0c0d0e0f000102030405060708090a0b0c0d0e0f07"
 	inBytes, err := hex.DecodeString(source)

diff --git a/types/key/uref.go b/types/key/uref.go
@@ -11,6 +11,10 @@ import (
 
 type UrefAccess = byte
 
+var (
+	ErrIncorrectPurseFormat = errors.New("incorrect uref format")
+)
+
 const (
 	UrefAccessNone = iota
 	UrefAccessRead
@@ -85,6 +89,10 @@ func (v URef) GobEncode() ([]byte, error) {
 
 func NewURef(source string) (res URef, err error) {
 	parts := strings.Split(source, "-")
+	if len(parts) != 3 {
+		return res, ErrIncorrectPurseFormat
+	}
+
 	payloadInBytes, err := hex.DecodeString(parts[1])
 	if err != nil {
 		return res, err