Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Camera-Streamer default branch #191

Conversation

BryanSmithDev
Copy link

Appears that Camera-Streamer repo now uses 'main' instead of 'master'

@mryel00
Copy link
Member

mryel00 commented Oct 23, 2023

We are already aware of that and this is basically a duplicate of #137. I will close it for the same reason.
There will be soon an update to main branch, but Bookworm exclusive at first, as Crowsnest fails to build on Bookworm with master branch (#188). As we (more like me) currently think that the Bookworm Raspberry Pi image is more like in a testing phase for the software inside the klipper universe.
So we will only update it for Bookworm that those people with Bookworm can use Crowsnest again. The Bookworm people will be like a testing group for this. We won't release it for Bullseye as we want to do enough testing on it first that we can assure that there aren't any issues like breaking changes or maybe missing features.

Btw updating it only like this won't make it possible to easily connect directly via the ip and you will have to use the /webcam endpoint to connect. This is because of the new parameter --http-listen=127.0.0.1, so the no_proxy=true option would need an update for camera-streamer too.
I think this is a good example of an unforeseen issue that could cause issues by just updating the branch.
Also this change will only work for new installations, so we need something for already installed systems too, that there won't be something like the update from Crowsnest v3 to v4 again.

@mryel00 mryel00 closed this Oct 23, 2023
@BryanSmithDev
Copy link
Author

Apologies. I checked prior pull requests before submitting but must have overlooked #137

Thanks for your work on Crowsnest / Mainsail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants