-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed-optimize '--each-while'. #153
Open
doublep
wants to merge
8
commits into
magnars:master
Choose a base branch
from
doublep:performance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 23, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 07079a5 - Browse repository at this point
Copy the full SHA 07079a5View commit details
Commits on Aug 27, 2015
-
Configuration menu - View commit details
-
Copy full SHA for f993e9f - Browse repository at this point
Copy the full SHA f993e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e9b068 - Browse repository at this point
Copy the full SHA 8e9b068View commit details -
Don't subtract time taken by GC when computing benchmark result.
How often GC is called and how much time it takes also indicates function's efficiency. We already call 'garbage-collect' before benchmarking.
Configuration menu - View commit details
-
Copy full SHA for e2592a0 - Browse repository at this point
Copy the full SHA e2592a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fce466 - Browse repository at this point
Copy the full SHA 5fce466View commit details -
Configuration menu - View commit details
-
Copy full SHA for dde71e1 - Browse repository at this point
Copy the full SHA dde71e1View commit details -
As a side effect, (-cons*) evaluates to nil rather than fail with an error. And with a silly number of arguments it no longer exceeds recursion depth limit.
Configuration menu - View commit details
-
Copy full SHA for 2d9a172 - Browse repository at this point
Copy the full SHA 2d9a172View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64de219 - Browse repository at this point
Copy the full SHA 64de219View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.