Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type #360

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

Fixed return type #360

wants to merge 1 commit into from

Conversation

apedicdev
Copy link

@apedicdev apedicdev commented Oct 6, 2023

Description

Fixed return type
Happy path
Code strict improvements

Fixed Issues (if relevant)

Issue with varnish cache enabled and categories breadcrumb
main.CRITICAL: Error: Call to a member function getName() on null in vendor/mageplaza/magento-2-blog-extension/Block/Category/Listpost.php:82
`

Manual testing scenarios

  1. Enable varnish cache
  2. Show blog categories in the menu
  3. Click on a category

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

Happy path
Code strict improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant