Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA-3273:Get Minimum Password Length from configuration #4319

Merged
merged 5 commits into from
Sep 19, 2024
Merged

PWA-3273:Get Minimum Password Length from configuration #4319

merged 5 commits into from
Sep 19, 2024

Conversation

glo11372
Copy link
Contributor

Description

  1. Go to stores->configurations->Customers->customer configuration ->password option , you can change here Minimum Password Length and then Venia ui it wil applied

Related Issue

Closes #4153

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added enhancement New feature or request pkg:venia-ui labels Aug 29, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 29, 2024 •
edited
Loading

Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against b8fc6b4

@glo11372 glo11372 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Aug 29, 2024
glo82145
glo82145 previously approved these changes Aug 29, 2024
View reviewed changes
glo82145
glo82145 previously approved these changes Sep 2, 2024
View reviewed changes
@glo82145 glo82145 changed the base branch from develop to release/14.1.0 September 19, 2024 08:39
@glo82145 glo82145 dismissed their stale review September 19, 2024 08:39

The base branch was changed.

@glo82145 glo82145 self-requested a review September 19, 2024 10:11
glo82145
glo82145 previously approved these changes Sep 19, 2024
View reviewed changes
@glo82145 glo82145 merged commit 8ec82f7 into release/14.1.0 Sep 19, 2024
7 checks passed
glo82145 added a commit that referenced this pull request Sep 19, 2024
@glo82145
Revert "PWA-3273:Get Minimum Password Length from configuration (#4319)"
823bf00 
This reverts commit 8ec82f7.
@glo82145 glo82145 mentioned this pull request Sep 19, 2024
Open
@glo82145 glo82145 deleted the PWA-3273 branch September 23, 2024 08:44
glo82145 added a commit that referenced this pull request Sep 30, 2024
@glo82145 @devops-pwa-codebuild @glo11372
Merge pull request #4331 from magento/sync-14.1.0
f2ccb87 
* v14.1.0-alpha.1

* PWA-3273:Get Minimum Password Length from configuration (#4319)

* PWA-3273:Get Minimum Password Length from configuration

* PWA-3273 adding updated testcases

* correcting minimum password code

* PWA-3341: Customet login (#4322)

---------

Co-authored-by: Aanchal Pawar <[email protected]>

* alpha1 issue (#4325)

* v14.1.0-alpha.3

* v14.1.0-alpha.4

* v14.1.0-beta.1

* v14.1.0

---------

Co-authored-by: devops-pwa-codebuild <[email protected]>
Co-authored-by: glo11372 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glo82145 glo82145 glo82145 approved these changes

Assignees

@glo82145 glo82145

Labels
enhancement New feature or request pkg:peregrine pkg:venia-ui Progress: done version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: Get Minimum Password Length from configuration
3 participants
@glo11372 @pwa-studio-bot @glo82145