Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum password length for admin user #39319

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
+3 −3
Open

Increase minimum password length for admin user #39319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e26414
increase minimum password length
torhoehn Nov 2, 2024
ed41109
Merge branch '2.4-develop' into feature/min-password-length
engcom-Hotel Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/User/Model/UserValidationRules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class UserValidationRules
/**
* Minimum length of admin password
*/
public const MIN_PASSWORD_LENGTH = 7;
public const MIN_PASSWORD_LENGTH = 12;

/**
* Adds validation rule for user first name, last name, username and email
Expand Down
4 changes: 2 additions & 2 deletions lib/web/mage/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,13 +685,13 @@ define([
return false;
}

if (pass.length < 7) {
if (pass.length < 12) {
return false;
}

return true;
},
$.mage.__('Please enter 7 or more characters, using both numeric and alphabetic.')
$.mage.__('Please enter 12 or more characters, using both numeric and alphabetic.')
],
'validate-customer-password': [
function (v, elm) {
Expand Down