Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invoice cancel from backend 404 error issue #39314

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Syamsg
Copy link

@Syamsg Syamsg commented Oct 31, 2024

Description (*)
Getting 404 error while canceling invoice form backend

Related Pull Requests

The issue comes from 3e63705#diff-f55a86b611d11bb9a801c4b16ba9ac4b17dab4c325d252b86d5d3a8b8275c291

Canceling invoices from the backend results in a 404 error due to the core controller class Magento\Sales\Controller\Adminhtml\Order\Invoice\Cancel using Magento\Framework\App\Action\HttpPostActionInterface instead of Magento\Framework\App\Action\HttpGetActionInterface. This misconfiguration prevents proper access, triggering the error.

Manual testing scenarios (*)

  1. create an order with an offline payment method
  2. create an invoice for the order (offline)
  3. cancel the invoice

Resolved issue
resolves #39298: Fix offline invoice capture (404)

Copy link

m2-assistant bot commented Oct 31, 2024

Hi @Syamsg. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fix offline invoice capture (404)
2 participants