Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar and spelling in error message #3345

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fredden
Copy link
Member

@fredden fredden commented Mar 4, 2022

Description

The error message does not make sense currently. Confusing 'then' for 'than' and vice-versa is a common mistake made in English. This pull request corrects both the grammar (inserting articles 'a' and 'the') and spelling (replace 'then' with 'than') in the error message so that it now makes sense.

https://www.merriam-webster.com/words-at-play/when-to-use-then-and-than

Manual testing scenarios

  1. Set up a catalogue with (at least) two inventory sources and (at least) one simple product in each (we only need two).
  2. Create a new bundle product and set this to 'ship bundle items together'
  3. Add one simple product and save the bundle product.
  4. Add another simple product (from a different inventory source) and save the bundle product.
  5. Observe text of error message.
    Note that we are intentionally triggering the error so that we can read the message. We do not expect the bundle product to be saved with both simple products attached.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

'then' indicates time, 'than' is used in comparisons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants