-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: e2e test cases for showkeys
and `showcommands'
#63
Merged
jamesgeorge007
merged 12 commits into
madlabsinc:next
from
rishabhKalakoti:feat/e2etests
Dec 28, 2019
Merged
chore: e2e test cases for showkeys
and `showcommands'
#63
jamesgeorge007
merged 12 commits into
madlabsinc:next
from
rishabhKalakoti:feat/e2etests
Dec 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhKalakoti
changed the title
e2e tests for 'teachcode showkeys'
e2e tests for 'teachcode showkeys' and 'teachcode showcommands'
Dec 28, 2019
jamesgeorge007
changed the title
e2e tests for 'teachcode showkeys' and 'teachcode showcommands'
chore: e2e test cases for Dec 28, 2019
showkeys
and `showcommands'
jamesgeorge007
requested changes
Dec 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments.
jamesgeorge007
approved these changes
Dec 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following e2e tests cases were written for the command
teachcode showkeys
:The following e2e tests cases were written for the command
teachcode showcommands
:addresses #28
Type of change
Checklist: