Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e test cases for showkeys and `showcommands' #63

Merged
merged 12 commits into from
Dec 28, 2019

Conversation

rishabhKalakoti
Copy link
Contributor

@rishabhKalakoti rishabhKalakoti commented Dec 28, 2019

Description

The following e2e tests cases were written for the command teachcode showkeys:

  • No config file present
  • No keys in the config file
  • Multiple keys in the config file

The following e2e tests cases were written for the command teachcode showcommands:

  • No config file present
  • Valid config file present

addresses #28

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rishabhKalakoti rishabhKalakoti changed the title e2e tests for 'teachcode showkeys' e2e tests for 'teachcode showkeys' and 'teachcode showcommands' Dec 28, 2019
@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Dec 28, 2019
@jamesgeorge007 jamesgeorge007 changed the title e2e tests for 'teachcode showkeys' and 'teachcode showcommands' chore: e2e test cases for showkeys and `showcommands' Dec 28, 2019
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments.

__e2e__/commands/showcommands.test.js Outdated Show resolved Hide resolved
__e2e__/commands/showcommands.test.js Outdated Show resolved Hide resolved
__e2e__/commands/showkeys.test.js Outdated Show resolved Hide resolved
__e2e__/commands/showkeys.test.js Outdated Show resolved Hide resolved
__e2e__/commands/showkeys.test.js Outdated Show resolved Hide resolved
__e2e__/commands/showkeys.test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@jamesgeorge007 jamesgeorge007 merged commit ae7a49d into madlabsinc:next Dec 28, 2019
@rishabhKalakoti rishabhKalakoti deleted the feat/e2etests branch December 28, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants