Implement exposure via EngineAPI #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This commit introduces the following changes to address issue hyperledger#6471: - A new method `engine_getClientVersionV1` has been added to `AbstractEngineGetPayload.java` to expose the `web3_clientVersion` via the EngineAPI. - The `build.gradle` file has been modified to set the `besu.version` system property during the build process, enabling the Java code to retrieve the project version at runtime. - The `ethereum:core` module has been added as a dependency in `build.gradle` to resolve import errors in the `ethereum/api` module. These changes allow Consensus Clients to access the execution client's name and version over the EngineAPI to include it in the proposed block graffiti.
|
this is totally on the wrong track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue hyperledger#6471 by exposing the via the EngineAPI, allowing Consensus Clients to access the execution client's name and version. Unit tests have been added to ensure correct functionality. Link to Devin run: https://preview.devin.ai/devin/0962ff35ebcc4fbb916acb31843b2c49