-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate github.com/spaolacci/murmur3 to github.com/twmb/murmur3 #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
amains/murmur3_migration
branch
from
August 17, 2020 19:48
f448dc0
to
0052f04
Compare
andrewmains12
changed the title
WIP: migrate github.com/spaolacci/murmur3 to github.com/twmb/murmur3
Migrate github.com/spaolacci/murmur3 to github.com/twmb/murmur3
Aug 24, 2020
andrewmains12
force-pushed
the
amains/murmur3_migration
branch
from
August 24, 2020 02:35
0052f04
to
7961818
Compare
vdarulis
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the library is a fine replacement.
andrewmains12
force-pushed
the
amains/murmur3_migration
branch
from
August 27, 2020 15:57
7961818
to
464d1eb
Compare
andrewmains12
force-pushed
the
amains/murmur3_migration
branch
from
August 27, 2020 17:13
464d1eb
to
1780f42
Compare
vdarulis
approved these changes
Aug 27, 2020
ChrisChinchilla
pushed a commit
that referenced
this pull request
Sep 22, 2020
g Add comment Squashed commit of the following: commit 2565ce89037ad856f62002fe430e134b85ffff88 Merge: 0ee043f5d 2f568eef5 Author: Chris Chinchilla <[email protected]> Date: Thu Sep 17 10:29:16 2020 +0200 Merge branch 'master' into braskin/hugo_site commit 2f568eef578847b603720c8b1a0698bee67111c7 Author: Matt Schallert <[email protected]> Date: Wed Sep 16 15:00:11 2020 -0700 [coord] Configurable blackholed SP's back from agg (#2641) There are cases where we want to ignore metrics for a given storage policy at the coordinator as they come back from the aggregator over m3msg. Specifically, the coordinators may still receive aggregated metrics with storage policies that they no longer have namespace configuration for. This PR allows dropping those metrics as they come back from the aggregator based on their storage policy. commit 273b2e365d3036bb75fb91bec488af3db6bb5ead Author: Alex Bublichenko <[email protected]> Date: Wed Sep 16 17:10:18 2020 -0400 [dbnode] Emit metric with dbnode health status (#2588) Emit metric with dbnode health status Problem: In a large m3db cluster, when a database node becomes non-functional (service fails to start or host is down), it may go unnoticed. If it goes unnoticed long enough, and one more node that owns the same shard(s) becomes non-functional, a quorum may be lost and block writes to the database. Solution: The connection pool in `src/dbnode/client/connection_pool.go` already does periodic health check from the client's node/process. Let that code emit a gauge metric with the result of the healthcheck. The metrics scope passed to `newConnectionPool` is already tagged with `hostID`. Since the healthcheck is done from the client, it implies that node is in M3DB placement and expected to be functional. Thus, alerting can be set up based on this metric alone. This behavior is optional, and disabled by default, to prevent accidental explosion of metric cardinality. When enabled, the callsites must ensure that the tags they set on the scope passed to m3db node client will not cause high cardinality of combinations with `hostID` tag. Considered Alternatives: 1. Emit a heartbeat metric from `src/dbnode/network/server/tchannelthrift/node/service.go`. Alerting on lost heartbeat requires knowledge about whether the node is in placement, i.e. expected to be functional. 2. Let independent monitoring/canary system actively probe healthcheck endpoint of every database node, determine whether the node is expected to be functional by comparing to M3DB placement data, and alert operator. Such solution would be ideal but has much higher cost. commit 0ee043f5d7b4c65df87e01caa013c30414a7ef1a Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 18:11:50 2020 +0200 Add Netlify TOML file Signed-off-by: ChrisChinchilla <[email protected]> commit a91c5eca33596dd94fe2c775eb8a5a22322d55a4 Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 18:00:16 2020 +0200 Final Signed-off-by: ChrisChinchilla <[email protected]> commit 356abb89bcbe816beaa4147606d550ab15c8fb8d Merge: febe502cf 47bd03b30 Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 17:55:50 2020 +0200 Merge branch 'master' into braskin/hugo_site Signed-off-by: ChrisChinchilla <[email protected]> # Conflicts: # docs/content/coordinator/_index.md # docs/content/coordinator/api/remote.md # docs/content/how_to/query.md # docs/content/m3query/api/query.md # docs/content/m3query/architecture/_index.md # docs/content/m3query/architecture/blocks.md # docs/content/m3query/architecture/fanout.md # docs/content/m3query/config/annotated_config.md # docs/content/m3query/config/annotated_config.yaml # docs/content/m3query/roadmap.md # docs/content/operational_guide/bootstrapping_crash_recovery.md # docs/content/operational_guide/monitoring.md # docs/content/operational_guide/repairs.md # docs/content/operational_guide/upgrading_m3.md # docs/content/overview/components.md # docs/coordinator/api/remote.md # docs/includes/headers_optional_read_all.md # docs/includes/headers_optional_read_limits.md # docs/includes/headers_optional_write_all.md # docs/index.md # docs/m3coordinator/api/remote.md # docs/m3db/architecture/storage.md # docs/m3query/api/index.md # docs/m3query/architecture/blocks.md # docs/m3query/architecture/fanout.md # docs/m3query/architecture/functions.md # docs/m3query/config/annotated_config.md # docs/m3query/config/annotated_config.yaml # docs/m3query/roadmap.md # docs/operational_guide/index.md # docs/operational_guide/mapping_rollup.md # docs/overview/media.md # docs/query_engine/api/index.md # docs/query_engine/architecture/blocks.md # docs/query_engine/architecture/fanout.md # docs/query_engine/config/annotated_config.md # docs/query_engine/config/annotated_config.yaml # docs/query_engine/roadmap.md # docs/static/aggregator.md commit febe502cf45a97de5d44babbff7a46e03dce765e Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 15:34:17 2020 +0200 Fix paths Signed-off-by: ChrisChinchilla <[email protected]> commit 8c300d5b1e53ca8326d07e7e514794c75bd33f6d Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 14:55:57 2020 +0200 Link fixes Signed-off-by: ChrisChinchilla <[email protected]> commit a4ca3db960bd51c7b593db954cfdfbb2b7b58c5a Merge: 3325ed863 45ad2f6d6 Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 14:17:18 2020 +0200 Merge commit '45ad2f6d6f1c23e387b8232b678e8c0d1093a5ca' into braskin/hugo_site commit 45ad2f6d6f1c23e387b8232b678e8c0d1093a5ca Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 14:17:18 2020 +0200 Squashed 'docs/themes/docs-theme/' changes from cc1e7c4b7..5103e6cc3 5103e6cc3 Remove centering git-subtree-dir: docs/themes/docs-theme git-subtree-split: 5103e6cc3427e97c469c2914246d4b46f7e27bd9 commit 3325ed863fb04e702a261e95293cec2ecca830e3 Author: ChrisChinchilla <[email protected]> Date: Wed Sep 16 14:17:06 2020 +0200 Fix links Signed-off-by: ChrisChinchilla <[email protected]> commit 47bd03b30de311113e6f70991f3e8aff4b57721d Author: Matt Schallert <[email protected]> Date: Tue Sep 15 18:47:31 2020 -0700 [docs] Add recent talks (#2639) commit 705f4f0d0fb9289787337a328e622091601b3f9c Author: Ryan Allen <[email protected]> Date: Tue Sep 15 20:54:45 2020 -0400 [dbnode] query limits - missed commit with feedback (#2640) commit b71785ea6dc91519be10834dc98dbf1e5b33a9f0 Author: Ryan Allen <[email protected]> Date: Tue Sep 15 15:19:25 2020 -0400 [dbnode] additional query limit on bytes read (#2627) commit 3aa2f51f7db827e35c7a0f35eab9e739a6aed8e5 Author: Linas Medžiūnas <[email protected]> Date: Tue Sep 15 21:13:41 2020 +0300 [large-tiles] Cross block reader changes plus Cross block iterator (#2612) * [dbnode] Add OrderedByIndex option for DataFileSetReader.Open (#2465) * [dbnode] Cross-block series reader (#2481) * [dbnode] AggregateTiles RPC - minimal E2E flow (#2466) * [large-tiles] Cross block reader changes plus Cross block iterator * Fix TestReadAggregateWrite * Fix TestShardAggregateTiles * Dummy * Fix TestReadAggregateWrite * typo * Convert spaces to tabs in rpc.thrift * Change capitalization of source/target namespace * Fix copyright year in large_tiles_test.go * Remove a noop * PR feedback * PR 2617 feedback * PR feedback * More PR feedback * Fix unit test * Reuse read objects during aggregation * Renamed StreamingMode to StreamingEnabled * PR feedback * Indentation * Address PR feedback * Skip flaky TestReadAggregateWrite Co-authored-by: arnikola <[email protected]> commit 8bcf5ac7cfba809fe71c501c85da1360888a877d Author: Rob Skillington <[email protected]> Date: Tue Sep 15 12:35:09 2020 -0400 [changelog] Update changelog for 0.15.14 release (#2638) commit 4b0fcb301a028aa8cecd46c100d8cde119737ccc Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 16:40:53 2020 +0200 Squashed 'docs/themes/docs-theme/' content from commit cc1e7c4b7 git-subtree-dir: docs/themes/docs-theme git-subtree-split: cc1e7c4b7be99f7dd8ceaacf11e6094f297c5989 commit 0d8b1fa8028e7bc3735c3542a489780dfc3b5396 Merge: 99b541e8d 4b0fcb301 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 16:40:53 2020 +0200 Merge commit '4b0fcb301a028aa8cecd46c100d8cde119737ccc' as 'docs/themes/docs-theme' commit 99b541e8d4b931a7220419ff6d084ce8c8b41abc Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 16:40:42 2020 +0200 Finalise glossary section Signed-off-by: ChrisChinchilla <[email protected]> commit 90e38bcae988b686710ef4c97527d4cfa71e1810 Merge: 6d887232a 2b5490b21 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 13:44:15 2020 +0200 Merge commit '2b5490b211202f7959328b4f7e9b387ef5e4b6ab' into braskin/hugo_site commit 2b5490b211202f7959328b4f7e9b387ef5e4b6ab Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 13:44:15 2020 +0200 Squashed 'docs/themes/docs-theme/' changes from 06ca4188b..dcbf4649b dcbf4649b Change glossary path REVERT: 06ca4188b Change glossary path git-subtree-dir: docs/themes/docs-theme git-subtree-split: dcbf4649bbaa43fc21c12cbdb936999d4b6719d8 commit 6d887232aaa0d87d6393d34a3df801b78fa7b0ff Merge: 957fb39ee ce857e005 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:28:23 2020 +0200 Merge commit 'ce857e005246025a90ec4ddd933cee7cfab4488a' into braskin/hugo_site commit ce857e005246025a90ec4ddd933cee7cfab4488a Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:28:23 2020 +0200 Squashed 'docs/themes/docs-theme/' changes from 7ac79e398..06ca4188b 06ca4188b Change glossary path REVERT: 7ac79e398 Change glossary path git-subtree-dir: docs/themes/docs-theme git-subtree-split: 06ca4188b1b040ce0f6334c50aeaecf8352c789f commit 957fb39ee8ca82897468a8e8c28ebe19f7e537f0 Merge: 571aed1f5 0ee3f033d Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:23:18 2020 +0200 Merge commit '0ee3f033d96a0af227c42edb71274a5e081a6e04' into braskin/hugo_site commit 0ee3f033d96a0af227c42edb71274a5e081a6e04 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:23:18 2020 +0200 Squashed 'docs/themes/docs-theme/' changes from d84a9b2e3..7ac79e398 7ac79e398 Change glossary path REVERT: d84a9b2e3 Change glossary path git-subtree-dir: docs/themes/docs-theme git-subtree-split: 7ac79e398305a2dbdbd88b3cd36e3b4c31e7483a commit 571aed1f54d3864ac58a95c02ed150696e119181 Merge: 8ed003229 fa9fe8b2f Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:13:12 2020 +0200 Merge commit 'fa9fe8b2f4055b89cd23bd9f0a8b50fb70918fe3' into braskin/hugo_site commit fa9fe8b2f4055b89cd23bd9f0a8b50fb70918fe3 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:13:12 2020 +0200 Squashed 'docs/themes/docs-theme/' changes from 4dba9dd2e..d84a9b2e3 d84a9b2e3 Change glossary path git-subtree-dir: docs/themes/docs-theme git-subtree-split: d84a9b2e3d94bc46382e79bb7b14775f5f9d29ff commit 8ed0032291651f7943f1991a13a887b5409c48a2 Author: ChrisChinchilla <[email protected]> Date: Tue Sep 15 12:13:03 2020 +0200 Remove defunct files Signed-off-by: ChrisChinchilla <[email protected]> commit 2ae97921754de9a06f5d55652d8f372a732d9dbe Author: Rob Skillington <[email protected]> Date: Tue Sep 15 00:39:21 2020 -0400 [dbnode] Add ability to configure writes to initializing shards (#2615) commit f83f5768f86647fca2c94e079334bd06035b57b1 Author: Rob Skillington <[email protected]> Date: Mon Sep 14 22:19:15 2020 -0400 [changelog] Update out of date changelog for 0.15.13 (#2636) commit 876cee834d65e80dcbbf05dbb63edd40602ee190 Author: Linas Medžiūnas <[email protected]> Date: Mon Sep 14 22:11:29 2020 +0300 [large-tiles] Large tiles aggregation flow (#2617) commit d38ff54aa5708474de0aec7a93f25a5f21542112 Author: Matt Schallert <[email protected]> Date: Mon Sep 14 07:22:09 2020 -0700 [m3admin] Allow /set for new placements (#2625) Previously `/set` required that a placement already exists in order to set it. This hinders operations such as preemptively creating a placement or replacing one that had been deleted via safe APIs. This PR allows using `/set` even if a placement didn't previously exist at that key. commit d5fff76fac215da9f96e751e916bb82cca6dc785 Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 15:33:05 2020 +0200 Squashed 'docs/themes/docs-theme/' content from commit 4dba9dd2e git-subtree-dir: docs/themes/docs-theme git-subtree-split: 4dba9dd2e0320cf0b9df05be01808a567781d5e3 commit 74ae18a546b202596f20a07f2b08eb4f1185b60f Merge: d707793aa d5fff76fa Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 15:33:05 2020 +0200 Merge commit 'd5fff76fac215da9f96e751e916bb82cca6dc785' as 'docs/themes/docs-theme' commit d707793aab7574c4d570d8718534e86a5cd24fb8 Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 15:32:55 2020 +0200 Move Signed-off-by: ChrisChinchilla <[email protected]> commit 93f3cd1b2d690edb4f88b30ef88e5347e66b9871 Merge: 42dbf1931 8b276ed17 Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 12:57:19 2020 +0200 Merge commit '8b276ed170a886058c276535a127567a38210426' as 'docs/themes/docs-theme' commit 8b276ed170a886058c276535a127567a38210426 Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 12:57:19 2020 +0200 Squashed 'docs/themes/docs-theme/' content from commit 4bb3340df git-subtree-dir: docs/themes/docs-theme git-subtree-split: 4bb3340df8857eb8cd07b70515b546287617ca60 commit 42dbf1931f80cc3edc0961eb3dfb6e5afdbfe441 Author: ChrisChinchilla <[email protected]> Date: Mon Sep 14 12:57:15 2020 +0200 Continue commit 07c034dfd6014ef9339d07403bc006963ecb9ed0 Author: teddywahle <[email protected]> Date: Mon Sep 14 01:03:57 2020 -0700 [query] Implemented movingSum, movingMax, movingMin (graphite functions) (#2570) commit e66e016d0249910df14f543164495e15a4cab0b5 Author: teddywahle <[email protected]> Date: Mon Sep 14 00:48:27 2020 -0700 [query] Add Graphite aliasByTags function (#2626) commit d3cd56679aa925dd7f3358abec2d46cae3215db8 Author: teddywahle <[email protected]> Date: Mon Sep 14 00:46:44 2020 -0700 [query] Implemented the Graphite `exponentialMovingAverage` function (#2622) commit 47eaa98b4e22ecc978ffc8210af2e1c1c1f3c26a Author: arnikola <[email protected]> Date: Thu Sep 10 18:18:01 2020 -0400 [query] Expose Graphite Compile method. (#2624) commit 82236667b206c156794fb4a71ec5905079b20236 Author: nate <[email protected]> Date: Thu Sep 10 11:00:49 2020 -0400 [dbnode] Fail if FetchTagged partially retrieves results due to error (#2610) commit d103bae30c1c9ea772608118f86e3a1c08f6f12d Author: ChrisChinchilla <[email protected]> Date: Wed Sep 9 12:36:58 2020 +0200 Remove netlify build from branch commit 7759733416d90026cd9db0a3c45b6e4b43cea3c7 Author: ChrisChinchilla <[email protected]> Date: Wed Sep 9 12:35:32 2020 +0200 Attempt to fix Netlify build commit d0586ca02914fcd4b1f90c67df4b5507674b5eb8 Author: Rob Skillington <[email protected]> Date: Tue Sep 8 23:00:28 2020 -0400 [query] Add explicit checking of context shifting for Graphite evaluation (#2604) commit 3c61bd7735d1ff5ffa4152b41b7cb1b880c60eae Author: Rob Skillington <[email protected]> Date: Tue Sep 8 22:45:40 2020 -0400 [dbnode] Add graphite tag pooling optimization for peer streaming memory savings (#2616) commit 4b657cba46a56bd491dc4436e91bdb298cd01575 Author: arnikola <[email protected]> Date: Tue Sep 8 18:12:32 2020 -0400 [dbnode] Fixes to wired list setup/teardown when used in tests (#2606) commit bb8002e136b2928f526e924d5c71883cad5cbebe Author: Bo Du <[email protected]> Date: Tue Sep 8 12:22:13 2020 -0600 [dbnode] Finalize seg and only close encoder once (#2611) commit 9f34f25b082e2944f1006c2bed5637902331a37a Author: Bo Du <[email protected]> Date: Tue Sep 8 09:54:00 2020 -0600 [dbnode] Add additional data snapshotting metrics (#2575) commit 7440118380d30537c29909a5a50e66f8e4391c2a Author: ChrisChinchilla <[email protected]> Date: Tue Sep 8 17:05:41 2020 +0200 More commit fbb59d9cf1fdebe38691867af31ca67f57cda77f Author: teddywahle <[email protected]> Date: Tue Sep 8 07:47:51 2020 -0400 [query] Implemented the Graphite `timeSlice` function (#2581) commit 2be52d19b064746f75f735c2e0e574f28a50ac1c Author: teddywahle <[email protected]> Date: Tue Sep 8 07:03:19 2020 -0400 [query] Implemented the Graphite `delay` function (#2567) commit 0bd0a85974dae5ebc5e62d9fd34d0c80328b21b2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Sep 8 06:27:03 2020 -0400 Bump http-proxy from 1.17.0 to 1.18.1 in /src/ctl/ui (#2600) commit 9f176c8d747f560db08c6a442d020b2100585724 Author: Ryan Allen <[email protected]> Date: Fri Sep 4 17:49:08 2020 -0400 [query] Series iterators processor (#2512) commit c2b227221a12fe2ef8f68968f4a6d46dceedb513 Author: Rob Skillington <[email protected]> Date: Fri Sep 4 11:04:52 2020 -0400 [dbnode] Move fetchTagged and aggregateRaw into the performant endpoints category (#2572) commit 76372dea6d83f865eb52c212caf3d3e95ceda999 Author: ChrisChinchilla <[email protected]> Date: Fri Sep 4 16:43:26 2020 +0200 Struct commit fb5b4a9beea2bc599281ef2b781b189cdcbf4dbf Author: Vytenis Darulis <[email protected]> Date: Fri Sep 4 10:10:58 2020 -0400 Fix races in m3msg consumer test code (#2589) Fixes various data races in m3msg consumer, producer tests (followup after #2583, updates #2540). Consumers are sharing message object pool, which makes go race detector go nuts - as a workaround, simply disabled pooling in src/msg/integration test suite. Also, cleaned up some unnecessary indirection in message structs, should reduce GC overhead overall. commit 98039ce4f0d4c9fd133d9d0fff0b9e1151ebd7f1 Author: Evan Yin <[email protected]> Date: Thu Sep 3 23:52:38 2020 -0700 [query] Add graphite function aggregateWithWildcards (#2582) Co-authored-by: Rob Skillington <[email protected]> commit f3f286463a7cfa9469b9d50fc118bebfce38ee43 Author: Rob Skillington <[email protected]> Date: Thu Sep 3 17:34:28 2020 -0400 [coordinator] Validate and do not send invalid metrics to aggregator for aggregation (#2593) commit 225a0c4f377f6c3d4b2b0a40a5bdc2533761323f Author: Rob Skillington <[email protected]> Date: Thu Sep 3 16:21:41 2020 -0400 [dbnode] Remove unused index offset and remove bad map[time.Time] usage (#2537) commit c036ebfaece5cd59fcf7d576505efd85c79bcb9c Author: nate <[email protected]> Date: Thu Sep 3 15:43:04 2020 -0400 [dbnode] Add Migrator for performing migrations and wire into fs bootstrapper (#2521) commit 4bccb6cea581aa96f16421f0f2a40991a513e908 Author: Benjamin Raskin <[email protected]> Date: Thu Sep 3 15:19:14 2020 -0400 [docs] Add `group_by` labels caveat to the docs (#2592) commit b7addc354953340db17c01774671f9a9569e89b2 Author: Vytenis Darulis <[email protected]> Date: Thu Sep 3 14:10:23 2020 -0400 Fix races triggered by TestRoundtrip in flushManager and bootstrapManager (#2586) Fix one of the few races that are always triggering on my env with go 1.14 Updates #2540 commit 929af23ab110f4aca74924426f5ea34ab9544c52 Author: Vytenis Darulis <[email protected]> Date: Thu Sep 3 14:09:38 2020 -0400 Update m3dbx/pilosa version (#2583) Partly addresses #2540 - tests no longer fail due to checkptr issues Had to also add a few replace directives due to ory/dockertest#212 and uber-go/atomic#60 After the dep update the only failing tests are data races in our own test code commit 492f76d0bb4922eb09f3e3d15b1d191bc8b65377 Author: Evan Yin <[email protected]> Date: Thu Sep 3 06:45:44 2020 -0700 [m3query] Add graphite function support - groupByNodes (#2579) commit 69b84213318f54d0f9d07df6c26425e0561dbfd0 Author: Vytenis Darulis <[email protected]> Date: Wed Sep 2 17:56:15 2020 -0400 Update etcd/boltdb dependency to fix panic in tests on go 1.14 (#2578) tests in src/cluster/services/heartbeat/etcd no longer fail due to checkptr unsafe sanity checks commit edd2dc883a5711076eb62396130811b2467b4ee3 Author: Vytenis Darulis <[email protected]> Date: Tue Sep 1 17:39:45 2020 -0400 Use unsafe-free murmur3 in bloom filter (#2577) Use misuses of unsafe-free murmur3 in bloom filter, and converge on a single library for murmur3 hashes. commit bf81bda1654b2fa5de27264e4063a5442c1ec418 Author: Rob Skillington <[email protected]> Date: Mon Aug 31 19:38:55 2020 -0400 [dbnode] Expose stream batch client options to config (#2576) commit 685baf715498d81b96ed8da033cc86efb39eb03f Author: teddywahle <[email protected]> Date: Mon Aug 31 17:30:05 2020 -0400 [query] Took windowSize parsing logic out of the movingAverage function (#2565) commit 1a6ae3bc313f67492a4d1dcc1dfaf33ea7275a57 Author: Vytenis Darulis <[email protected]> Date: Mon Aug 31 13:15:53 2020 -0400 Reduce ObjectPool overhead (#2376) Reduce instrumentation and raw get/put overhead due to contention/false-sharing, and add more benchmarks. commit 84b9c92064ffa3b8496ad463bb9480997c1fc630 Author: teddywahle <[email protected]> Date: Fri Aug 28 13:08:21 2020 -0700 [query] Rename testMovingAverage function to more general name testMovingFunction (#2566) commit e74c381eb1eaff1c27717080fbf0e84d643bb3fc Author: ChrisChinchilla <[email protected]> Date: Fri Aug 28 12:42:48 2020 +0200 Further fixing commit 3e357ace4f5f924e4f6155de81a11c46796f8c89 Author: ChrisChinchilla <[email protected]> Date: Fri Aug 28 12:10:14 2020 +0200 Continue commit 6b50f87f46de0e6e5e4c29fcf622217cbbf210b8 Author: ChrisChinchilla <[email protected]> Date: Fri Aug 28 11:44:52 2020 +0200 Continue commit efddf37ab765cbf7ef4dea795b7b7d8818649678 Author: ChrisChinchilla <[email protected]> Date: Fri Aug 28 11:37:08 2020 +0200 Start migration to Hugo commit e0eff5b921fa1993dd9e0cb6c074f2bbda717e94 Author: Andrew Mains <[email protected]> Date: Thu Aug 27 18:05:28 2020 -0400 Use blackfriday.v2 to avoid version conflicts; eliminate fsnotify pin (unused) (#2562) This diff performs some more go.mod version cleanups. Overall goal here is to impose fewer requirements on downstream projects importing M3 as a library. We're only really touching deps around the edges here; fsnotify isn't used by the project (comes through by way of viper, which itself is barely used by the project), and blackfriday (also barely used) can and should be referenced by the gopkg.in/russross/blackfriday.v2 path, to support working in projects which have both v1 and v2. commit 3aa9fb71420c341194b41202d1f66e5201534a03 Author: Rob Skillington <[email protected]> Date: Thu Aug 27 17:33:38 2020 -0400 [dbnode] Fix case insensitive regexp flag implementation for metrics selector (#2564) commit 6f1dad2053d5663d1bc0266b0cf1eb9b744f4d13 Author: Gibbs Cullen <[email protected]> Date: Thu Aug 27 16:43:19 2020 -0400 Correct community meeting month for linked recording (#2563) commit 99477fc131a373b8d226dfd4bb42795f13c9ba0c Author: Andrew Mains <[email protected]> Date: Thu Aug 27 13:19:33 2020 -0400 Migrate github.com/spaolacci/murmur3 to github.com/twmb/murmur3 (#2539) * WIP: migrate github.com/spaolacci/murmur3 to github.com/twmb/murmur3 * Remove murmur3 test, which is not needed going forward commit 98e92698db5a708fea92a6c51b23fe79e561c9cf Author: Andrew Mains <[email protected]> Date: Wed Aug 26 18:36:24 2020 -0400 Bump etcd client to 3.4.10, remove GRPC and etcd replace directives (#2555) What this PR does / why we need it: This PR updates the etcd client version we use to work with later versions of GRPC. It also removes the replace directives for both GRPC and etcd. My suspicion based on talking with @notbdu is that these replace directives aren't strictly necessary, and were a function of dependency import from glide. Removing them hopefully will make version maintenance easier (no guarantees). A note about the etcd dep and version: etcd 3.4 is in a weird state wrt go modules; tl;dr is that the switch to go modules for go 3.4 broke etcd as a library with go modules; see etcd-io/etcd#11154 for details. The recommendation from that thread is to use a hash based version string (method described in etcd-io/etcd#11154 (comment)). We were previously doing this in a replace directive; I've switched the dependency to do it in the require block directly. IIUC, this propagates the dependency to downstream code using m3 as a library, whereas the replace directive does not. commit bfd7712b733046932c21d2b98a9a5cabb9c5cd54 Author: Andrew Mains <[email protected]> Date: Wed Aug 26 09:07:58 2020 -0400 [m3cluster] Split out m3cluster placement service into stateless and stateful classes #2552 (#2552) What this PR does / why we need it: This PR splits out some placement service functionality into a stateless placement.Operator class; placement.Service remains the same. Currently, placement.Service is responsible for both performing manipulations on placement.Placement objects (node adds etc) and for storing the results back. This is inconvenient for certain automation cases, where you may need to perform multiple operations on a placement before storing it back. In my particular case, I'm doing: ``` curPlacement := svc.Placement() // check with external system if placement changes are needed // do placement changes svc.CheckAndSet(modifiedPlacement) ``` commit 5bd09a837305465e1d70564eb38d81758b54003a Author: Justin Chan <[email protected]> Date: Mon Aug 24 16:16:37 2020 -0400 Visibility into and ability to limit number of encoders per block (#2516) * Max encoders per block setting * New metric: histogram of number of active encoders per block * New metric: counter of number of writes dropped due to max encoders setting commit ff49172f9e27910aa0f53a1b17be6f362f35e908 Author: arnikola <[email protected]> Date: Sat Aug 22 23:54:27 2020 -0400 [changelog] Changelog for 0.15.12 (#2554) * [changelog] Changelog for 0.15.2 * Add details about tag lifecycle related to carbon ingestion Co-authored-by: Rob Skillington <[email protected]> commit ef327eef8e7e0a43e24d4e712ba6789edf238560 Author: arnikola <[email protected]> Date: Sat Aug 22 23:52:41 2020 -0400 [query] Fix graphite functions, aggregation bug (#2549) commit 69a7bdc65c23655c7c1ade2708e45335b174dea8 Author: Rob Skillington <[email protected]> Date: Sat Aug 22 01:27:50 2020 -0400 Fix changelog formatting commit 96d46917d1eb34c4663c3a23e6da59a2f87bf188 Author: Rob Skillington <[email protected]> Date: Sat Aug 22 01:16:14 2020 -0400 [changelog] Update changelog for 0.15.11 (#2553) commit 11c142289a0b76313b379a2d9f1967123001c1db Author: Rob Skillington <[email protected]> Date: Sat Aug 22 01:14:08 2020 -0400 [dbnode] Extend lifetime of compactable index segments for aggregate queries (#2550) commit 9646a57888c280f5c0f10a3f96d1b80165e4b9c8 Author: Rob Skillington <[email protected]> Date: Thu Aug 20 20:31:56 2020 -0400 Update media.md commit 7294275cc47f3ee0b12705849503b7a3e64559c7 Author: shreyassrivatsan <[email protected]> Date: Thu Aug 20 16:28:05 2020 -0700 [coordinator] Support for augmenting tags in mapping rules (#2414) This change adds the ability to augment additional tags on metrics targeted towards graphite ingestion. - __m3_graphite_aggregation__ adds the aggregation tag as the last numbered tag for graphite metrics - __m3_graphite_prefix__ prepends the provided path to the appropriate numbered tags. Secondly, the change additionally adds support for metric types and allows to specify metrics types in mapping/rollup rules. Thirdly, the change provides a config flag to disable auto mapping rules. commit f9c486989eb9f0194c800b2d756c954b67813c3c Author: Ryan Allen <[email protected]> Date: Thu Aug 20 16:30:00 2020 -0400 [media] Add CNCF Webinar 2020 talk to docs media page (#2548) commit d303c285c5e2e1570164479a2cf899edd782a2d6 Author: Bo Du <[email protected]> Date: Wed Aug 19 20:20:59 2020 -0600 Update for 0.15.10 (#2547) commit f8d8400461f44d9603d195ee434efe2e7c7f6f9b Author: Bo Du <[email protected]> Date: Wed Aug 19 20:20:23 2020 -0600 Fix enqueue readers n2 info file reading problem. (#2546) commit c7620307a7d733b04b84ec3969917b91469d49c5 Author: Chris Chinchilla <[email protected]> Date: Mon Aug 17 17:10:52 2020 +0200 Remove unused parameter for another buildkite script (#2538) commit 1bbca4b438f4ef4574018eb1cca9c04c343c3f14 Author: ChrisChinchilla <[email protected]> Date: Mon Aug 17 16:29:09 2020 +0200 Start quickstart rewrite commit 97279a4e91cd111d22576ac2be5e47779622b670 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 16:33:02 2020 +0200 Add hugo publish dir to gitignore commit fdd275d9f972c9308489dcc023972366290ce2c1 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 16:25:58 2020 +0200 Update publish path commit e942b4cf5f750d1bad722b59fc711ba3e32bc4ba Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 16:22:20 2020 +0200 Miss-formed YAML broke build commit 62b2faccd7ade413b6b437e92e1e7428a049b7c9 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 16:20:25 2020 +0200 Add netlify config for this preview branch commit 3232961afa7d04f43b0c15353854895cf8d3a110 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 16:06:43 2020 +0200 Remove rogue submodule commit d8842698d42211b9117ce98959c33d16c126cedd Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 15:56:55 2020 +0200 Change submodule path commit 3e42ed8f216de26deebc008fc1c3207bd7058c18 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 15:53:59 2020 +0200 Add theme as submodule commit ce92f326785750df40021715c852de55878f7572 Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 14:37:49 2020 +0200 Testing content commit 40d6f9f43c569af2052ba37bdf9e956c583af7da Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 14:37:33 2020 +0200 Update config commit accedc19d77a9f6b42b03965c8e87c7d466987da Author: ChrisChinchilla <[email protected]> Date: Thu Aug 13 14:37:25 2020 +0200 remove folder commit fb842c537acca8c65796ab2a85bb6a9bf17ec4ff Author: nate <[email protected]> Date: Wed Aug 12 12:21:27 2020 -0400 [dbnode] Add ToVersion1_1 migration task (#2520) commit 1b7e6a758a3a4aba9091dd0188ca724e11d90ede Author: Bo Du <[email protected]> Date: Wed Aug 12 09:29:49 2020 -0600 [changelog] Update for 0.15.9 (#2536) commit 51301bdca3125caca0d0f943cd25afe8aeeac068 Author: Chris Chinchilla <[email protected]> Date: Wed Aug 12 17:29:08 2020 +0200 Remove unused parameter from buildkite script (#2535) commit 22f0ea0661348be9defc6421f352b6f55bd84544 Author: Bo Du <[email protected]> Date: Tue Aug 11 17:21:20 2020 -0600 [dbnode] Do not unnecessarily sort index entries in bootstrap paths (#2533) commit cdb82482a1b3434152f6fd4c6ea8e6110fe644d0 Author: Gibbs Cullen <[email protected]> Date: Tue Aug 11 14:28:34 2020 -0400 Adding M3 meetup recordings to "media" page in M3 docs (#2495) * Update media.md * Update docs/overview/media.md * Update docs/overview/media.md * Update media.md Co-authored-by: Rob Skillington <[email protected]> commit 7adc47a65e4b19b68d2873c903f8f0d046b03f11 Author: Chris Chinchilla <[email protected]> Date: Tue Aug 11 10:04:06 2020 +0200 [DOCS] Update docs dependency versions and remove unneeded arguments (#2524) * Update dependency versions and remove unneeded arguments * Add back newline commit 23856b1f996056b35d776e7f6311bc46cb52208c Author: Chris Chinchilla <[email protected]> Date: Tue Aug 11 09:29:30 2020 +0200 Update MKDocs extensions to include admonitions and remove critic markup (#2527) Co-authored-by: Rob Skillington <[email protected]> commit 9b14aa38810ea8cfa734aa09b30e3ed1334d2cc1 Author: Gibbs Cullen <[email protected]> Date: Mon Aug 10 16:29:24 2020 -0400 Update link to Twitter account (#2530) commit 495b49c8a1b7277ffe950f2a25ca199b1bac5e3e Author: Rob Skillington <[email protected]> Date: Mon Aug 10 15:46:27 2020 -0400 Update aggregator.md (#2529) commit 6e8840e8db5d28b8732d56f6e0f11125e20d5b98 Author: nate <[email protected]> Date: Mon Aug 10 14:00:39 2020 -0400 [dbnode] Add migration configuration and options (#2519) commit a8012291e42ad9f675dc251f12aa939b422bc0ba Author: Bo Du <[email protected]> Date: Thu Aug 6 17:00:41 2020 -0600 [dbnode] Background cold flush process (#2508) commit 975b99c94611ab58f2481a5efb14fe3f2b26d942 Author: Asaf Mesika <[email protected]> Date: Fri Aug 7 01:03:03 2020 +0300 Tiny spelling mistake fix in FAQ (#2448) Co-authored-by: Benjamin Raskin <[email protected]> commit 5da4a96c37ac7728fa2cdaaba16cc556dba37a33 Author: Matt Schallert <[email protected]> Date: Wed Aug 5 16:08:23 2020 -0400 [query] Respect M3Cluster headers in Namespace Get (#2518) commit 843a3f4d33ff4a37b6538054483adffbdf8a3ab8 Author: Linas Medžiūnas <[email protected]> Date: Wed Aug 5 20:10:18 2020 +0300 [docs] Minor docs fix - uninitialized_topology instead of topology_uninitialized (#2510) commit a6bba33142def2d7d2e135800fa38efd608a8dc6 Author: Rob Skillington <[email protected]> Date: Tue Aug 4 21:52:22 2020 -0400 [docs] Add initial M3Aggregator documentation (#1741) commit e4c4f61efeb00479873d7f2f26bc08e762907eca Author: Rob Skillington <[email protected]> Date: Fri Jul 31 21:20:43 2020 -0400 [changelog] Update for 0.15.8 (#2507) commit 6830a8cb434532945a3565923b68c8e093c97064 Author: Rob Skillington <[email protected]> Date: Fri Jul 31 21:12:22 2020 -0400 Revert "[dbnode] Background cold flush process (#2460)" This reverts commit 3ac68a2ac1894b2931e24e51253d06eb6a6d96bf. commit a9cba02cc34a4d47d7bad161c014336139ab5d85 Author: arnikola <[email protected]> Date: Fri Jul 31 20:55:06 2020 -0400 [changelog] 0.15.7 (#2506) commit efd2505de077d641a7d720d4995f9e2655e9fde5 Author: arnikola <[email protected]> Date: Fri Jul 31 20:54:25 2020 -0400 [query] Fix to regexes with leading wildcard (#2505) commit f8b63790ea06fc2a5646e2d2c94da8a0e127eb4a Author: Gibbs Cullen <[email protected]> Date: Fri Jul 31 18:16:39 2020 -0400 Adding link to M3 meetup recordings (#2494) commit 3ac68a2ac1894b2931e24e51253d06eb6a6d96bf Author: Bo Du <[email protected]> Date: Thu Jul 30 14:59:27 2020 -0600 [dbnode] Background cold flush process (#2460) commit 643511440dbe588fc11984a30c389ffa3c66a3d2 Author: arnikola <[email protected]> Date: Thu Jul 30 12:05:31 2020 -0400 [query] Standardize parse function logic (#2499) commit 6a805d38ef95bb9b7f560c3eca53a7a388f45d71 Author: Rob Skillington <[email protected]> Date: Mon Jul 27 14:56:30 2020 -0400 [dbnode] Strict JSON unmarshal (disallow unknown fields) for raw HTTP/JSON DB node APIs (#2490) commit 6763227dd442c6a4e14f720396a9362d8e69f0fa Author: Rob Skillington <[email protected]> Date: Fri Jul 24 13:10:17 2020 -0400 Revert "Revert "[dbnode] Validate individual index entries on decode instead of entire file on open (#2468)"" This reverts commit c9454929daa9ff3a52956d6c43b7105a4bf89138. commit ff17acb3e56991d7ee113693db500f063a978f47 Author: Rob Skillington <[email protected]> Date: Fri Jul 24 13:09:29 2020 -0400 [changelog] Update changelog for 0.15.6 (#2489) commit c9454929daa9ff3a52956d6c43b7105a4bf89138 Author: Rob Skillington <[email protected]> Date: Fri Jul 24 13:08:17 2020 -0400 Revert "[dbnode] Validate individual index entries on decode instead of entire file on open (#2468)" This reverts commit bba274f90b122e69cb2a52c894ef790fe18f8af2. commit 82a9d324e38987e5a692ec2980258c76b118a744 Author: Linas Medžiūnas <[email protected]> Date: Fri Jul 24 18:26:46 2020 +0300 [query] Update histograms.test based on new Prometheus release (#2488) commit 5e40989427b2a62d6ba2e5c38787fa02ecc32d8e Author: Rob Skillington <[email protected]> Date: Thu Jul 23 20:56:11 2020 -0400 [query] Parse programmatic min/max time as [start_retention, end_retention) (#2487) commit 6a2ee8cbff92b03999b347ecbe395bd6c8bc4c20 Author: arnikola <[email protected]> Date: Thu Jul 23 17:57:19 2020 -0400 [query] Special case particular Prom matchers (#2479) commit db1f9c52a689eccee1068db6a1d53b33478b74bb Author: arnikola <[email protected]> Date: Thu Jul 23 13:58:39 2020 -0400 [query] Auto-set reasonable range on remote match (#2483) commit 122bd56cdc3040301232f0ff932f7e33c66a57a1 Author: arnikola <[email protected]> Date: Thu Jul 23 11:52:55 2020 -0400 [query] Set default Prometheus evaluation interval (#2482) commit 91b8c384f2f9d77b02aa4d3505dd651250dfb6c6 Author: Rob Skillington <[email protected]> Date: Thu Jul 23 11:00:00 2020 -0400 [docs_test] Exclude testing certain links for docs_test (#2484) commit 635d3adc929be4d0308fe2bef1116bcbfd216fe4 Author: Linas Medžiūnas <[email protected]> Date: Thu Jul 23 16:56:17 2020 +0300 [aggregator] Fix metrics registration issues (#2443) commit 957fa836e74ddbf1fad29e1b6ebe81dccd356cab Author: Rob Skillington <[email protected]> Date: Wed Jul 22 16:09:22 2020 -0400 [dbnode] Protect field postings list iter with write vs read lock as it mutates (#2476) commit 27c7ce231a0a748627495d1940d94b49b86c5c40 Author: arnikola <[email protected]> Date: Wed Jul 22 14:27:52 2020 -0400 [aggregator] Standardize aggregator network io (#2431) commit bba274f90b122e69cb2a52c894ef790fe18f8af2 Author: nate <[email protected]> Date: Wed Jul 22 13:39:49 2020 -0400 [dbnode] Validate individual index entries on decode instead of entire file on open (#2468) * Add schema.VersionChecker VersionChecker allows us to make decisions around how to proceed depending on the Major and Minor Version in the index info file. * Add DecoderStreamWithDigest * Wire up index entry checksum validation on decode commit ecf8d804aed5eb226d012098c33698db0a7e2454 Author: Rob Skillington <[email protected]> Date: Wed Jul 22 02:51:08 2020 -0400 [dbnode] Add namespace runtime options for runtime per-namespace config changes (#2446) commit 255bef553d2db0941d8a51382cf05cffc1c71c06 Author: nate <[email protected]> Date: Tue Jul 21 11:16:07 2020 -0400 [dbnode] Add IndexEntryChecksum field to entries in index file (#2455) * Rename Checksum on IndexEntry to DataChecksum In preparation for adding a checksum for the index entry itself, rename the existing checksum field on the IndexEntry to clarify it's usage. * Encode and decode IndexEntryChecksum field * Update storage documentation to add IndexEntryChecksum * Bulletproof decoder case statement; improve tests commit 3da7b7ead92f959cd4538432d0a071c3a64c20a7 Author: nate <[email protected]> Date: Tue Jul 21 10:52:56 2020 -0400 Update README.md (#2474) commit 87ba6e21d409d62b871417fa817866d0c6b4d31c Author: Ryan Allen <[email protected]> Date: Mon Jul 20 14:23:46 2020 -0400 [dbnode] Index flush doc caching via DocRef tests (#2459) commit 570f91a6720ad9eb47ae015fb29de421276355ec Author: Linas Medžiūnas <[email protected]> Date: Fri Jul 17 13:12:59 2020 +0300 [dbnode] Fix flaky TestNamespaceIndexFlushSuccess (#2469) commit c8ba3c2a4443dd781cbb1b9df942540f9a6ae7fa Author: Bo Du <[email protected]> Date: Tue Jul 14 18:37:29 2020 -0400 Align test & index's view of now. (#2464) commit ddf305d5c6b0c6f0daf44cbe4493f5dbef9902e7 Author: Benjamin Raskin <[email protected]> Date: Tue Jul 14 16:46:44 2020 -0400 [docs] Add more rollup rules docs (#2462) commit cd3095402a518bb334cd9d6d9820d83545da937e Author: Rob Skillington <[email protected]> Date: Tue Jul 14 15:19:25 2020 -0400 [docs] Add simple rollup rules example (#2461) commit e85c52943ccd80a5314d82646b973e5b364d2951 Author: Ryan Allen <[email protected]> Date: Mon Jul 13 11:45:11 2020 -0400 [dbnode] Reference existing doc in shard map on index flush (#2456) commit f68f7c1db38d8a86db8f1b5bbe3a66e5f7327da8 Author: Rob Skillington <[email protected]> Date: Mon Jul 13 11:20:15 2020 -0400 Add log message on placement set parse error (#2457) commit e48539a1764a7471e65d3bb4fb605cf775481110 Author: nate <[email protected]> Date: Fri Jul 10 18:04:36 2020 -0400 [dbnode] Add MinorVersion to Info file (#2453) * Add MinorVersion to Info file In prepation for checksumming index files at the entry level, add the concept of minor version. Minor version can be used to introduce non-breaking changes in a controlled fashion. * Add note to go.mod about upgrading msgpack commit 73fe6acd394abb8f9dce77fbfc76326527a3c8f1 Author: Matt Schallert <[email protected]> Date: Fri Jul 10 11:46:12 2020 -0400 [db] Set gauge when DB requires restart (#2454) commit 824f3c5cd5f501a7223a9cc13c84f262b7f78398 Author: Matt Schallert <[email protected]> Date: Thu Jul 9 12:55:30 2020 -0400 [query] tags: Include ID in duplicate tag error (#2435) It's difficult to debug duplicate tags without knowing the underlying ID. commit 097de0631c0c9771b1c650d5947d09cd32ce821e Author: Rob Skillington <[email protected]> Date: Wed Jul 8 11:41:34 2020 -0400 [dbnode] Expose cluster total shards and replicas as metrics (#2452) commit daaa0c8ab65fcf5245448db29114cc2b44b03645 Author: arnikola <[email protected]> Date: Tue Jul 7 22:30:53 2020 -0400 [query] Carbon fetch for metrics with no separator (#2450) commit 78a9858da4220aa5892342d2ecbc7da4f96110f4 Author: Rob Skillington <[email protected]> Date: Tue Jul 7 20:11:01 2020 -0400 [dbnode] Add TestFieldsTermsIteratorIterateTermsAndRestrictByQuery (#2449) commit 59663999d434fa593d7987d669f49cdb49db2719 Author: Rob Skillington <[email protected]> Date: Tue Jul 7 16:05:25 2020 -0400 [dbnode] Always use block aggregate query for aggregate queries and intersect term results with query postings list (#2441) commit 009a57a71f2a4d301bea3be806f152a2094a89b5 Author: Rob Skillington <[email protected]> Date: Mon Jul 6 04:03:38 2020 -0400 [changelog] Update for 0.15.5 release (#2447) commit 09ff0df9650d563ea5670e6bd7d3ff369c87477f Author: Rob Skillington <[email protected]> Date: Mon Jul 6 03:56:20 2020 -0400 [dbnode] Add continuous file profile with RPC endpoint (#2416) commit c4d48d13c75b5302ca4ff3eb808e050fd4d813dd Author: Linas Medžiūnas <[email protected]> Date: Fri Jul 3 09:03:48 2020 +0300 [docs] Minor documentation fixes (#2438) commit 0426458596120683767458126b03e44b13473bfb Author: Bo Du <[email protected]> Date: Thu Jul 2 01:14:40 2020 -0400 [dbnode] Check if data exists on disk for warm index flushes (#2428) commit e8947ef7ff48b0be600518c8568039b1971339da Author: arnikola <[email protected]> Date: Wed Jul 1 23:02:52 2020 -0400 [query] Add tag filters for query results from config (#2440) commit e601e67f656ca61d5d16334f1aa151e67315d2f0 Author: Rob Skillington <[email protected]> Date: Wed Jul 1 21:32:42 2020 -0400 [docs] Add M3-Restrict-By-Tags-JSON example to docs (#2437) commit 4401470a3f0bb81c5c03fc87f833c8ca4546b32f Author: arnikola <[email protected]> Date: Wed Jul 1 00:48:51 2020 -0400 [changelog] 0.15.4 changelog (#2436) commit 630946b01b28a69c08856bb521890bb31592f8db Author: Rob Skillington <[email protected]> Date: Wed Jul 1 00:48:14 2020 -0400 [query] Add ability to set restrict by tags defaults in config (#2430) commit b4be7b1356d72a4052ecf21c6d027cad5a027b07 Author: Rob Skillington <[email protected]> Date: Tue Jun 30 23:09:34 2020 -0400 [dbnode] Fast block rotations, zero-copy of ID and fields on series index metadata re-indexing (#2423) commit c373017b19293f9ce24164d4757431f9141906d4 Author: Rob Skillington <[email protected]> Date: Sun Jun 28 18:34:10 2020 -0400 [dbnode] Negate possibility of point in time segment rotation returning query error (#2432) commit 333fea9f4bf017599093d83337c764a2b2074283 Author: Ryan Allen <[email protected]> Date: Wed Jun 24 14:07:32 2020 -0400 [dbnode] Fix limit integration tests (#2425) commit 35021ceaccf616018931e7d58a6b5d772cdeb6e9 Author: Rob Skillington <[email protected]> Date: Tue Jun 23 19:46:52 2020 -0400 [docs] Add documentation for per query limits with config and headers (#2427) commit ec34fe0c8a1347931d55421e2a4d3af4049affde Author: arnikola <[email protected]> Date: Tue Jun 23 18:17:27 2020 -0400 [changelog] Update changelog to 0.15.3 (#2426) commit 6f053544fe06070878a07f047cada1e2376d6bbd Author: Ryan Allen <[email protected]> Date: Tue Jun 23 17:03:00 2020 -0400 [dbnode/query] Limit docs per query (#2415) commit c41e28edbe8822e045cd727998b310725d6c5978 Author: Gediminas Guoba <[email protected]> Date: Tue Jun 23 12:49:49 2020 +0300 [query] In one-to-one with labels matcher only labels should be included (#2417) commit af0074da6683b8a5a05e66ecad38139f39738b2b Author: arnikola <[email protected]> Date: Sun Jun 21 10:47:22 2020 -0400 [comparator] Refactor series loader (#2420) commit 00f6dc1f7d37ceb061b0c13bf19dddf1395b8a13 Author: Ryan Allen <[email protected]> Date: Fri Jun 19 18:51:50 2020 -0400 [dbnode] Query stats tracker for metrics and limits (#2405) commit 440171d70e2df2b329ceeacde8ba08c802be171f Author: Linas Medžiūnas <[email protected]> Date: Fri Jun 19 09:46:34 2020 +0300 [query] Uncomment fixed promql test cases (#2419) commit 6a1b046b7e3ec17314f99a4bf6601cfbdf60903d Author: Bo Du <[email protected]> Date: Thu Jun 18 20:28:04 2020 -0400 [dbnode] Ensure index data consistency (#2399) commit 967f455ec7299eebbb5b24289e993d73afff7950 Author: Rob Skillington <[email protected]> Date: Thu Jun 18 17:04:59 2020 -0400 [build] Only fail codecov checks if drop in coverage of 5% (#2421) commit 2f9897dca72d9ae0bb3a6083bc2f4aeb87b6e30e Author: Rob Skillington <[email protected]> Date: Thu Jun 18 16:48:51 2020 -0400 Revert "[dbnode] Additional require-exhaustive test cases (#2412)" (#2422) This reverts commit 669609d3a18392d1c64902259e1705acf2ae7892. commit 8fff5825cdcf5e87c408474d78a269d1c50e7630 Author: Rob Skillington <[email protected]> Date: Wed Jun 17 16:06:24 2020 -0400 [docs] Add InfluxDB write endpoint to documentation (#2410) commit 669609d3a18392d1c64902259e1705acf2ae7892 Author: Ryan Allen <[email protected]> Date: Wed Jun 17 14:43:42 2020 -0400 [dbnode] Additional require-exhaustive test cases (#2412) commit 9d98e794d687e07cec117e2b884d661b0c6c500d Author: Linas Medžiūnas <[email protected]> Date: Wed Jun 17 20:48:37 2020 +0300 [query] Fix PhysicalPlan.shiftTime (#2413) commit b12af4de01f7056f41e29b1ef7b1ce68d1796b48 Author: shreyassrivatsan <[email protected]> Date: Mon Jun 15 17:15:40 2020 -0700 [coordinator] Mapping rules with a drop policy should also apply to unaggregated metrics (#2262) commit 900b316446ef0d03d607aff775783c5642ddd174 Author: Rob Skillington <[email protected]> Date: Mon Jun 15 17:31:07 2020 -0400 [dbnode] Fix duplicate ID insertions causing transient error when flushing index block (#2411) commit 1ee74f992f1fdf0949f1e8160a52b0e89177879e Author: Gibbs Cullen <[email protected]> Date: Mon Jun 15 11:54:48 2020 -0400 Adding Office Hours info to Readme (#2404) commit 975a60e3fab6fee40d9fc8b532106ec4a2286cdd Author: Gediminas Guoba <[email protected]> Date: Mon Jun 15 08:29:00 2020 +0300 [query] query engine router refactored (#2391) commit 8210e6c3ac9147a3742d62be0196a944e70154c1 Author: Rob Skillington <[email protected]> Date: Sat Jun 13 00:17:02 2020 -0400 [changelog] Prepare changelog for 0.15.2 commit 70ebf1b82411f6284accd8bef3a5782292457d0b Author: Rob Skillington <[email protected]> Date: Sat Jun 13 00:14:54 2020 -0400 [query/dbnode] Fix require exhaustive propagation of require exhaustive option through RPC (#2409) commit b770a20c8eef24831eba7143c679f30e03269750 Author: arnikola <[email protected]> Date: Fri Jun 12 11:53:35 2020 -0400 [query] Allow query to consolidate series by tags (#2370) commit 007c4bded270e626b5791699e2acd58fc68b2117 Author: Linas Medžiūnas <[email protected]> Date: Fri Jun 12 17:23:00 2020 +0300 [query] Fix metrics registration issue for nativePromReadInstantHandler (#2406) commit d373a1588777f5df909a73f41d68f374734c9a83 Author: Rob Skillington <[email protected]> Date: Fri Jun 12 09:55:16 2020 -0400 [changelog] Prepare changelog for 0.15.1 (#2407) commit 44d463ab615a2d77169e1f74e8f2e131ae79a0e5 Author: Ryan Allen <[email protected]> Date: Thu Jun 11 17:51:05 2020 -0400 [dbnode/query] Optionally error if query exceeds series limit via RequireExhaustive config (#2400) commit ccf5669a02288b387ea06e9a060455323e7f7794 Author: Linas Medžiūnas <[email protected]> Date: Thu Jun 11 21:34:32 2020 +0300 [query] Return resultType scalar for scalar results (#2393) commit 586e72bb223057dec694f8135f40a6489b1f2dbe Author: Matt Schallert <[email protected]> Date: Thu Jun 11 13:19:59 2020 -0400 [query] Fix Content-Type for OpenAPI handler (#2403) commit 2c4f65c05752fb00f9740b8a17e1c3ead8cf3bab Author: Gediminas Guoba <[email protected]> Date: Thu Jun 11 15:31:44 2020 +0300 [m3comparator] adaption of Prometheus testdata to validate m3query (#2361) commit 0d01d62d082428993fd09f7f369d48eb719e58f9 Author: Linas Medžiūnas <[email protected]> Date: Thu Jun 11 07:55:23 2020 +0300 [query] Workaround for non monotonic histogram buckets (#2388) commit 1576ae14890bb0224657c8778f0f644b17eb691d Author: Linas Medžiūnas <[email protected]> Date: Wed Jun 10 23:24:21 2020 +0300 [dbnode] Report a histogram of loaded docs per query (#2381) commit 29db6b334f49ef2d0d081c6742c77188415ce787 Author: Linas Medžiūnas <[email protected]> Date: Wed Jun 10 23:00:45 2020 +0300 [query] Respect keepNans option for instant queries (#2390) commit 5fbb290c5fb8fcb851f145ebb02808767d3e0dd8 Author: Matt Schallert <[email protected]> Date: Wed Jun 10 11:39:33 2020 -0400 [m3admin] API: Support namespace retention updates (#2383) We currently don't have a way to modify a namespaces retention with the m3admin APIs. However doing so is somewhat tricky, as it's unsafe to update any arbitrary namespace field. This PR supports safely updating a namespace in-place. The only respected field is retention period, as we know that to be safe. Attempts to modify any other field will inform the user the field is immutable. commit d9ef1bb426e874a33b5c72f81ff2102853265344 Author: Linas Medžiūnas <[email protected]> Date: Wed Jun 10 07:06:27 2020 +0300 [query] Exclude metrics name from without-based aggregations (#2396) commit 6142b34cf432c1b4427693758b84e39284db87f3 Author: Rob Skillington <[email protected]> Date: Tue Jun 9 19:26:06 2020 -0400 [coordinator] Ingesting aggregated metrics with invalid params should always log error (#2398) commit 76e92ff10de2b3734e76f3e37756344f83dce019 Author: Rob Skillington <[email protected]> Date: Tue Jun 9 17:08:18 2020 -0400 [build] Build release binaries with goreleaser using Go 1.13 (#2397) commit 3aee98cc0cbb3db448d43ef9a910aee30d6dbffe Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jun 8 13:31:06 2020 -0400 Bump websocket-extensions from 0.1.3 to 0.1.4 in /src/ctl/ui (#2394) commit b239df452f8e5d5199ce7471f1f7dd3aefaa01f8 Author: Bo Du <[email protected]> Date: Thu Jun 4 17:56:51 2020 -0400 [dbnode] Add documentation on flushing/snapshotting (#2385) commit a5272630d06b05cfa56452022fa4e4277eef0ef5 Author: arnikola <[email protected]> Date: Thu Jun 4 16:32:48 2020 -0400 [dtest] Initial docker integration test migration (#2340) commit d64afbabd5f4745a3ca8c87923d5648646ca3f0d Author: Linas Medžiūnas <[email protected]> Date: Thu Jun 4 08:53:04 2020 +0300 [query] Sort grouped aggregate outputs by tags (#2386) commit dcef4ff7bffaa8409d65e3a75d191942b9608679 Author: Rob Skillington <[email protected]> Date: Wed Jun 3 12:24:14 2020 -0400 [changelog] Update changelog for 0.15 release (#2387) commit 6d45a3c914efe029cebf8adc8de4cd73b11556e8 Author: Gediminas Guoba <[email protected]> Date: Wed Jun 3 19:14:08 2020 +0300 [query] Return M3-Results-Limited header when series limit is reached for Prometheus query engine (#2371) commit d3e91a7341ddd3482ea3b0e726f940ba82746b3a Author: Bo Du <[email protected]> Date: Tue Jun 2 22:13:59 2020 -0400 [all] Upgrade Go runtime to 1.13, use go modules, remove glide and use MADVISE=dontneed for dbnode (#2221) commit fb31c2e96d45e08cbd17e528561607c568c9099e Author: Chao Wang <[email protected]> Date: Mon Jun 1 16:06:41 2020 -0400 [msg] Fix metrics (#2372) commit c415cbc4ce528fb20dc4611f1e6ef9b05f8a4513 Author: Bo Du <[email protected]> Date: Mon Jun 1 15:13:59 2020 -0400 Remove Evict() API and call Close(). (#2382) commit 63f5a1a23ada2b05763e4eede307c917ccb338bf Author: Linas Medžiūnas <[email protected]> Date: Sat May 30 08:29:52 2020 +0300 [comparator] Support generating random histogram metrics (#2379) commit eec6a8ef4c10c71d7d380568aee86dfa08cc962c Author: Gediminas Guoba <[email protected]> Date: Fri May 29 12:34:22 2020 +0300 [m3comparator] query without metric name (#2335) commit bcb34f30ba7531465bfd4d880402af606054860a Author: Linas Medžiūnas <[email protected]> Date: Fri May 29 11:41:51 2020 +0300 [dbnode] Fix query_stats_total_docs_per_block counter (#2357) commit 3fc3cd1d8d555e3371b7b1b65cf752410e818fd0 Author: Linas Medžiūnas <[email protected]> Date: Fri May 29 08:55:22 2020 +0300 [query] Support parsing/matching of non matrix results (#2374) commit 5288dbf1b992d350fa7b1ac32bb7cce2e9e4c8a5 Author: shreyassrivatsan <[email protected]> Date: Thu May 28 20:33:06 2020 -0700 [coordinator] Support additional metric types on remote write (#2368) commit bfd99794433ca7182f6267e6b206380b37bcae6a Author: Rob Skillington <[email protected]> Date: Wed May 27 15:36:15 2020 -0400 [query] Add Prometheus engine metrics and upgrade to Prometheus 2.17.2 (#2369) commit 19159775cd9e97d391a1e3a6bf9e57d14272080f Author: arnikola <[email protected]> Date: Tue May 26 23:59:47 2020 -0400 [dbnode] Add option for experimental TChannel server use (#2367) commit 4706104bb20249ae19deb665eddf6200addfb6cf Author: Rob Skillington <[email protected]> Date: Tue May 26 23:31:18 2020 -0400 [dbnode] Add ability to configure peer streaming shard concurrency (#2364) commit 4f68265d224b440459de115618a8f595fdd74988 Author: arnikola <[email protected]> Date: Tue May 26 22:01:20 2020 -0400 [thrift] Hotfix and test for service metadata. (#2366) commit 412d6a89476a57b1749ec604c41498ac5335e8cd Author: arnikola <[email protected]> Date: Tue May 26 21:21:01 2020 -0400 [dbnode] Clean up new client connection generator (#2363) commit a4bb6361dbdbdf14a0efbe7dda05458871f887fb Author: Rob Skillington <[email protected]> Date: Tue May 26 20:35:29 2020 -0400 [coordinator] Add write/read retry calls vs final-error metrics by default (#2365) commit 8530c1156571011d43dd4eaa045dac3eae3035f3 Author: arnikola <[email protected]> Date: Tue May 26 20:10:13 2020 -0400 [thrift] Add metadata to node health checks (#2362) commit fbc7098e4ab8d70ee5fd23100c3bb082da60751f Author: Linas Medžiūnas <[email protected]> Date: Wed May 27 02:18:06 2020 +0300 [dbnode] Allow construction of QueryStatsTracker to use instrument opts (#2358) commit 438fc07343d009385b3801370a5a7b4441c50542 Author: Linas Medžiūnas <[email protected]> Date: Tue May 26 21:11:54 2020 +0300 [query] Fix tag mismatch message text (#2360) Co-authored-by: Rob Skillington <[email protected]> commit 2efacb960f628931d1290c23e3020db926f63140 Author: shreyassrivatsan <[email protected]> Date: Tue May 26 09:42:34 2020 -0700 Add metric type and source to timeseries message (#2359) Co-authored-by: Jerome Froelich <[email protected]> commit a8664596e4b59cbf1b2b866605b3ed758516722c Author: Gediminas Guoba <[email protected]> Date: Tue May 26 13:30:03 2020 +0300 [m3comparator] a feature to clear data on memory storage (#2312) commit 83638309685d3e47945f69c051e52ae698651bf5 Author: Gediminas Guoba <[email protected]> Date: Tue May 26 13:13:48 2020 +0300 [query] Native PromQL integration into m3coordinator (#2343) commit bdcbc0da07b2c45cbf12d793175344722ab1e4d1 Author: Linas Medžiūnas <[email protected]> Date: Mon May 25 12:27:31 2020 +0300 [comparator] Filter query results by tag matchers (#2319) commit b1db8264e81d756f53c85220db018ba81d2f596f Author: Linas Medžiūnas <[email protected]> Date: Mon May 25 10:21:38 2020 +0300 [query] Set warning headers in remote read debug endpoint (json format) (#2356) commit 58b87a2f0c9b81b7c6d460c8ea6395b3256e0fbe Author: Rob Skillington <[email protected]> Date: Fri May 22 19:20:18 2020 -0400 [coordinator] Add multi-process config for on-prem process scaling (#2292) commit ff0f21f9a4044853a182f2b3f10cfa04685e4676 Author: Rishabh Jain <[email protected]> Date: Sat May 23 03:59:24 2020 +0530 [dbnode] Emits metrics to monitor divergence of shards as db repair progresses (#2334) commit 7cdde90c32c46fa30f6ed6a785a483725db4d13c Author: Bo Du <[email protected]> Date: Fri May 22 14:18:15 2020 -0400 [dbnode] Let cold writes through and seal cold created index blocks (#2354) commit 47f13a10d52ec3c7fb0132f5001e90f3c7cb1b22 Author: Gibbs Cullen <[email protected]> Date: Thu May 21 23:00:57 2020 -0400 Add meetup group for community meetings to README.md (#2353) * Update README.md * Update README.md * Update README.md Co-authored-by: Rob Skillington <[email protected]> commit 8c43c36906eaa37ded1648d83004d1e527a91c73 Author: Bo Du <[email protected]> Date: Thu May 21 22:36:23 2020 -0400 [dbnode] Operate upon on cold mutable segments in index block (#2352) commit eb618cc7d799b79a44e7b8e0867864576908dae4 Author: Bo Du <[email protected]> Date: Thu May 21 19:18:39 2020 -0400 [dbnode] Add cold mutable segs and expose APIs to rotate/evict (#2348) commit 8455fda90f3074a8dfc07f3d6e7ecec91a9e607f Author: Bo Du <[email protected]> Date: Thu May 21 17:33:29 2020 -0400 [dbnode] Refactor index block into mutable segments and block (#2345) commit b8c3033bfe7a4ef242b76e7e3609b7a5845d39bb Author: Matt Schallert <[email protected]> Date: Thu May 21 16:24:04 2020 -0400 [ci] Update ci-scripts w/ codecov changes (#2350) commit 39f7821ebda9f0e72ca906660a37a938bb117054 Author: arnikola <[email protected]> Date: Fri May 15 13:12:12 2020 -0400 [query] Fix metrics for forwarding latency (#2342) commit be91b6ed90cd16e69ccab35bafc3cbc976b72b41 Author: Bo Du <[email protected]> Date: Thu May 14 21:33:36 2020 -0400 [dbnode] Fix first write logic (#2341) commit 82c4362ee6bbe797689809db4f17b7eb95e18bdc Author: Rob Skillington <[email protected]> Date: Wed May 13 23:25:38 2020 -0400 [dbnode] Adjust default pool sizes based on workloads at various organizations (#2337) commit 8ae5852c90dac94c51e4357d3e0e18034ba976ee Author: Bo Du <[email protected]> Date: Wed May 13 18:41:16 2020 -0400 [dbnode] Ensure block leasers are eventually consistent w/ shard state (#2338) * Rip out block retriever from bootstrappers. commit 105952dd6ce6c7cf8c9295719e83a8195324e401 Author: Bo Du <[email protected]> Date: Wed May 13 18:20:26 2020 -0400 [dbnode] Skip index queue for cold writes (#2329) commit 9b30fb47d9d4e5aaebeb08fef053457ad1af7e0e Author: Bo Du <[email protected]> Date: Wed May 13 14:38:50 2020 -0400 [dbnode] Track when a series bucket was first written. (#2333) commit dc65b7df4e579c956b43f4d2b8cb5f7a87760675 Author: Linas Medžiūnas <[email protected]> Date: Wed May 13 17:30:01 2020 +0300 [comparator] Generate random multi series metrics (#2318) commit 1651ffd8358081b6c7695103236ab69351c66c02 Author: Rob Skillington <[email protected]> Date: Mon May 11 18:41:11 2020 -0400 [dbnode] Sort by unmarked index entries for indexing (#2328) commit 269035400eafc169dcb27a5ce361ec1188f9c443 Author: arnikola <[email protected]> Date: Sun May 10 08:43:47 2020 -0400 [query] Update backend storage transform interface (#2330) commit ecba7b12e495dbbd49b2523c9334f074b034fdd6 Author: arnikola <[email protected]> Date: Fri May 8 17:18:24 2020 -0400 [query] Allow custom storage transform (#2327) commit bd814b5303b35a72d944d0aa1999382877b08771 Author: Justin Chan <[email protected]> Date: Fri May 8 16:31:24 2020 -0400 Fix upserting consecutive protobuf writes (#2323) * Don't skip encoding if both value and annotation is the same as previous commit 5ef05b9fe034c72b38ac5ae921519de7b04bb953 Author: Łukasz Szczęsny <[email protected]> Date: Fri May 8 19:18:29 2020 +0200 [docs] Cleanup README files (#2326) commit 6ed118bc91a1d94175716810754549c3ade61109 Author: Gibbs Cullen <[email protected]> Date: Fri May 8 12:56:50 2020 -0400 edits to operator section commit 706f9bcdb28119f77d92b1fd6b97aa4e850c7568 Author: Rishabh Jain <[email protected]> Date: Fri May 8 21:32:53 2020 +0530 [dbnode] Allow reading/writing log entries greater than flushMaxBytes from/to commit log (#2277) * Allows writing log entries bigger than flush size in commit log - Resolves a bug in chunk writer which resulted bufio to skip wrong number of bytes while trying to perform a buffered write of commit log entry. - Resolves an issue an commit log reader allowing commit log reader to read chunk's greater than flush size. Chunk reader was trying to peek data in the chunk to compute its checksum. This resulted in buffer full error for large chunk sizes. This commit resolves this issue by loading the chunk data into a new buffer to compute its checksum instead of trying to peek for data in bufio's fixed length buffer. - Introduces unit tests to test for all the above mentioned fixes with different filled buffer capacities to make sure chunk reader/write can gather log entries of any size across buffers and chunks without any error. commit 016785738d461150371bb0c03f9e0b104359c5f0 Author: Gibbs Cullen <[email protected]> Date: Fri May 8 11:01:58 2020 -0400 initial formatting done commit 7cb39a9f30265ffb72699448248d8267feffe0d4 Author: Bo Du <[email protected]> Date: Fri May 8 00:32:45 2020 -0400 Properly handle cold index errors if cold writes are enabled. (#2325) commit a651e554f3244b3b98c989a12edec68fb1f89968 Author: Bo Du <[email protected]> Date: Fri May 8 00:09:16 2020 -0400 Don…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches out github.com/spaolacci/murmur3 for github.com/twmb/murmur3 as a workaround for spaolacci/murmur3#29.
Property tests suggest functional equivalence to the existing library, and the benchmarks quoted by the library maintainers suggest perf is mostly equivalent, though it does take a 30% hit for use of safe code on small byte arrays:
If desired I can bake this change in a shadow environment with reasonable traffic to vet out the performance. I'm also happy to add more M3DB specific microbenchmarks, though some guidance on what would be helpful would be appreciated. First thought is to get a sampling of ID lengths and run them through.