Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: Use the wlroots backend with unknown Wayland compositors #2161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion panel/lxqtpanelapplication.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ void LXQtPanelApplicationPrivate::loadBackend()
}
}

if ( preferredBackend.isEmpty() && xdgCurrentDesktops.contains( QStringLiteral("wlroots") ) )
if ( preferredBackend.isEmpty() && xdgSessionType == QStringLiteral("wayland") ) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wlroots backend should be used only if wlroots is included. That inclusion means, "we know that it works with this Wayland compositor." The dummy backed should be used with unsupported compositors.

{
qDebug() << "Specialized backend unavailable. Falling back to generic wlroots";
preferredBackend = QStringLiteral("wlroots");
Expand Down