Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update lxqtbacklight_backend.c #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damianatorrpm
Copy link

adds 3 cmd options (I use them to pipe the output as the original show method does not exactly what it says / I need)

    } if( !strcmp(argv[n], "--show-max") ) {
            show_max();
            return 0;
        } if( !strcmp(argv[n], "--show-value") ) {
            show_val();
            return 0;
        } if( !strcmp(argv[n], "--show-driver") ) {

Copy link
Member

@luis-pereira luis-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damianatorrpm You are right, it doesn't do what it says. Also the --show option documentation needs revision (it doesn't states what it outputs).

Doesn't
lxqt-backlight_backend --show | cut -d' ' -f1 --> driver
lxqt-backlight_backend --show | cut -d' ' -f2 --> max_value
lxqt-backlight_backend --show | cut -d' ' -f3 --> actual_vaule

cut it ?

@damianatorrpm
Copy link
Author

damianatorrpm commented Apr 9, 2019

Well it would show the same output, yet I think that is messy, as one has to remember the syntax for cut, as well as it makes it harder to be used due to ' characters in QPocess::startDetached('lxqt-backlight') and similar. In the end one can use a shell script to just find the directory for the backlight driver, but than there is lxqt-backlight_backend.
Do you mean the description of the commands would need updating before such a pr can be accepted?

@luis-pereira
Copy link
Member

@damianatorrpm lxqt-backlight_backend is a privileged executable (pkexec allowed without password).
I'm trying to keep it as simple as possible.
I'm not sure I understood what you are trying to achieve. Can you explain it in a more detailed manner ?

The format of the show command needs to be added. In this OR another PR.

@agaida agaida changed the title Update lxqtbacklight_backend.c WIP: Update lxqtbacklight_backend.c Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants