Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: Consume websocket pings for stderr #1380

Merged
merged 1 commit into from
Nov 16, 2024
Merged

exec: Consume websocket pings for stderr #1380

merged 1 commit into from
Nov 16, 2024

Conversation

stefanor
Copy link
Contributor

Fixes: #1289

@stefanor stefanor changed the title Consume websocket pings for stderr exec: Consume websocket pings for stderr Nov 15, 2024
@stgraber
Copy link
Member

@stefanor could you update the commit message to include the Signed-off-by line?

@stgraber
Copy link
Member

Very nice catch. I had started to look into this a few weeks ago, but the time needed to reproduce and debug was a bit annoying :)

@stefanor
Copy link
Contributor Author

Very nice catch. I had started to look into this a few weeks ago, but the time needed to reproduce and debug was a bit annoying :)

@cjwatson pointed me in the right direction, because he'd debugged something similar before. Once I knew what to look for, it was obvious what was missing.

@stefanor
Consume websocket pings for stderr
d098f46 
Fixes: lxc#1289

Signed-off-by: Stefano Rivera <[email protected]>
@stgraber stgraber merged commit ce639bb into lxc:main Nov 16, 2024
30 checks passed
@stgraber
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stderr unexpectedly closed on lxc exec process
2 participants
@stefanor @stgraber