-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incusd/instances/publish: Fix base metadata #1374
Conversation
There actually is a bug that prevents the re-writing of EDIT: The same test is performed to conditionnally add the file to the archive (well it conditions the |
The whole if/else block could be replaced by :
That way we can ensure the creationDate, expiry, properties are all overwritten in all cases, as expected. |
We shouldn't rewrite the properties, priorities should only be generated if the metadata doesn't already exist as the user may have properly pre-created/updated the metadata through |
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
e1aa98f
to
aa4c961
Compare
Closes lxc#1371 Signed-off-by: Stéphane Graber <[email protected]>
Alright, looks like the state of the current |
Closes #1371