incus/file/create: Use SFTP client instead of file API

Signed-off-by: HassanAlsamahi <[email protected]>

cmd/incus/file.go

@@ -22,7 +22,7 @@ import (
 	"github.com/spf13/cobra"
 	"golang.org/x/crypto/ssh"
 
-	"github.com/lxc/incus/v6/client"
+	incus "github.com/lxc/incus/v6/client"
 	cli "github.com/lxc/incus/v6/internal/cmd"
 	"github.com/lxc/incus/v6/internal/i18n"
 	internalIO "github.com/lxc/incus/v6/internal/io"
@@ -288,9 +288,15 @@ func (c *cmdFileCreate) Run(cmd *cobra.Command, args []string) error {
 		}, fileArgs.Content)
 	}
 
-	err = resource.server.CreateInstanceFile(resource.name, targetPath, fileArgs)
+	var paths []string
+	if c.flagType != "symlink" {
+		paths = []string{targetPath}
+	} else {
+		paths = []string{targetPath, symlinkTargetPath}
+	}
+	err = c.file.sftpCreateFile(resource, paths, fileArgs)
+
 	if err != nil {
-		progress.Done("")
 		return err
 	}
 
@@ -928,6 +934,62 @@ func (c *cmdFilePush) Run(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
+func (c *cmdFile) setOwnMode(sftpConn *sftp.Client, targetPath string, args incus.InstanceFileArgs) error {
+
+	err := sftpConn.Chown(targetPath, int(args.UID), int(args.GID))
+	if err != nil {
+		return err
+	}
+
+	err = sftpConn.Chmod(targetPath, fs.FileMode(args.Mode))
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
+func (c *cmdFile) sftpCreateFile(resource remoteResource, targetPath []string, args incus.InstanceFileArgs) error {
+	sftpConn, err := resource.server.GetInstanceFileSFTP(resource.name)
+	if err != nil {
+		return err
+	}
+
+	defer sftpConn.Close()
+
+	switch args.Type {
+	case "file":
+		_, err := sftpConn.OpenFile(targetPath[0], os.O_CREATE)
+		if err != nil {
+			return err
+		}
+
+		err = c.setOwnMode(sftpConn, targetPath[0], args)
+		if err != nil {
+			return err
+		}
+
+	case "directory":
+		err := sftpConn.MkdirAll(targetPath[0])
+		if err != nil {
+			return err
+		}
+
+		err = c.setOwnMode(sftpConn, targetPath[0], args)
+		if err != nil {
+			return err
+		}
+
+	case "symlink":
+		err = sftpConn.Symlink(targetPath[0], targetPath[1])
+		if err != nil {
+			return err
+		}
+
+	}
+	return nil
+}
+
 func (c *cmdFile) recursivePullFile(d incus.InstanceServer, inst string, p string, targetDir string) error {
 	buf, resp, err := d.GetInstanceFile(inst, p)
 	if err != nil {