Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: add SetTimeout #166

Merged
merged 1 commit into from
Sep 26, 2023
Merged

container: add SetTimeout #166

merged 1 commit into from
Sep 26, 2023

Conversation

mihalicyn
Copy link
Member

@mihalicyn mihalicyn commented Jan 17, 2023

Extend container API with a new method SetTimeout
which allows to set SO_RCVTIMEO for LXC client socket.

Issue #4257

Signed-off-by: Alexander Mikhalitsyn [email protected]

See lxc/lxc#4257

@mihalicyn
Copy link
Member Author

lxc/lxc#4260

@stgraber stgraber marked this pull request as draft January 25, 2023 04:40
@stgraber
Copy link
Member

Switched to Draft until the liblxc side is finalized.

@mihalicyn
Copy link
Member Author

@stgraber It looks like we have a problem with our PPA for LXC after master branch was renamed to main in https://github.com/lxc/lxc

Last build was 6 weeks ago https://launchpad.net/~ubuntu-lxc/+archive/ubuntu/lxc-git-master

@stgraber
Copy link
Member

Ah yeah, that will need a bit of fixing

@mihalicyn
Copy link
Member Author

@stgraber Stéphane, please approve workflows run for this PR.

@stgraber
Copy link
Member

I'm not seeing a pending run, just looks like it failed

@mihalicyn mihalicyn force-pushed the settimeout_api_ext branch 2 times, most recently from 9167a19 to f6ddf3f Compare September 22, 2023 12:26
@mihalicyn
Copy link
Member Author

I'm not seeing a pending run, just looks like it failed

Hm, yes, but there was a pending run. Weird.

Now I see:

3 workflows awaiting approval

Extend container API with a new method SetTimeout
which allows to set SO_RCVTIMEO for LXC client socket.

Issue #4257

Signed-off-by: Alexander Mikhalitsyn <[email protected]>
@stgraber stgraber merged commit ccae595 into lxc:v2 Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants