Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make hero fancy #187

Closed
wants to merge 16 commits into from
Closed

feat: make hero fancy #187

wants to merge 16 commits into from

Conversation

zeitiv
Copy link
Collaborator

@zeitiv zeitiv commented Dec 14, 2022

No description provided.

@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 14, 2022 22:40 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 14, 2022 22:40 Inactive
@cedricschwyter cedricschwyter added this to the v1.0 milestone Dec 14, 2022
@cedricschwyter cedricschwyter linked an issue Dec 14, 2022 that may be closed by this pull request
make space fancy #175
Open
@cedricschwyter cedricschwyter added enhancement General request to enhance feature A new feature labels Dec 14, 2022
@zeitiv zeitiv added security Security-related topics javascript Pull requests that update Javascript code and removed security Security-related topics labels Dec 14, 2022
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 14, 2022 22:49 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 14, 2022 22:49 Inactive
cedricschwyter
cedricschwyter previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@cedricschwyter cedricschwyter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need to add the ts-particles dependency to be buildable again, other than that, this looks good

@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 15, 2022 11:40 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 15, 2022 11:40 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 15, 2022 11:49 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 15, 2022 11:49 Inactive
cedricschwyter
cedricschwyter previously approved these changes Dec 15, 2022
View reviewed changes
@cedricschwyter
Copy link
Member

liking how this is starting to look. let's tone it down a bit, add some geometric lines and put this as a general background for the whole landing and auth pages

@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 15, 2022 17:11 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 15, 2022 20:19 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 15, 2022 20:19 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 16, 2022 16:35 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 16, 2022 16:35 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 16, 2022 23:19 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 16, 2022 23:19 Inactive
@cedricschwyter cedricschwyter added the destroy-review-app destroys a heroku review app label Dec 16, 2022
@github-actions github-actions bot removed the destroy-review-app destroys a heroku review app label Dec 16, 2022
@cedricschwyter cedricschwyter added the create-review-app creates a heroku review app label Dec 17, 2022
@github-actions github-actions bot removed the create-review-app creates a heroku review app label Dec 17, 2022
@cedricschwyter cedricschwyter added the destroy-review-app destroys a heroku review app label Dec 17, 2022
@cedricschwyter cedricschwyter temporarily deployed to lumium-space-pr-187 December 17, 2022 23:07 Inactive
@cedricschwyter cedricschwyter temporarily deployed to lumium-api-pr-187 December 17, 2022 23:07 Inactive
@github-actions github-actions bot removed the destroy-review-app destroys a heroku review app label Dec 17, 2022
@cedricschwyter
Copy link
Member

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricschwyter cedricschwyter cedricschwyter left review comments

@edbingo edbingo Awaiting requested review from edbingo

@ReddixT ReddixT Awaiting requested review from ReddixT

Assignees

@zeitiv zeitiv

Labels
enhancement General request to enhance feature A new feature javascript Pull requests that update Javascript code
Projects
lumium workspaces
Status: ✅ Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

make space fancy
2 participants
@zeitiv @cedricschwyter