Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TablePlus #1164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mackup/applications/cyberduck.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@
name = Cyberduck

[configuration_files]
# based on https://trac.cyberduck.io/wiki/help/en/faq#Preferencesandapplicationsupportfileslocation
Library/Application Support/Cyberduck
Library/Containers/ch.sudo.cyberduck/Data/Library/Application Support/Cyberduck
Library/Group Containers/G69SCX94XU.duck/Library/Application Support/duck
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is gonna work, it's specific to each computer no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. These paths are documented in the Cyberduck wiki page.

https://trac.cyberduck.io/wiki/help/en/faq#Preferencesandapplicationsupportfileslocation

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Did you test the config yourself? e.g. mackup backup followed by mackup uninstall and mackup restore?

I suggest splitting those 2 apps in 2 PR so we can merge the easy one and dig into the other one.

Copy link
Author

@rizkysyazuli rizkysyazuli Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The mackup backup command works fine. i have it in my personal .mackup config folder. But i haven't tried running the uninstall and restore command.

But i just noticed the path in line 7 doesn't exists. If i'm not mistaken, that was for an older version of Cyberduck.

Library/Containers/ch.sudo.cyberduck/Data/Library/Application Support/Cyberduck

But sure. i will try to split those PR a bit later. sorry for the trouble.

Library/Preferences/ch.sudo.cyberduck.plist
5 changes: 5 additions & 0 deletions mackup/applications/tableplus.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[application]
name = TablePlus

[configuration_files]
Library/Application Support/com.tinyapp.TablePlus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need Library/Application Support/com.tinyapp.TablePlus/Data in order to save the connections.