-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TablePlus #1164
Open
rizkysyazuli
wants to merge
5
commits into
lra:master
Choose a base branch
from
rizkysyazuli:tableplus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
098ad92
added Cyberduck bookmark location for the sandboxed & later versions
rizkysyazuli 69af5bc
Merge pull request #1 from rizkysyazuli/cyberduck-update
rizkysyazuli 060f7b4
Add support for iTermocil
rizkysyazuli 6b6fd49
Merge branch 'master' of github.com:lra/mackup
rizkysyazuli 03b7980
add support for TablePlus
rizkysyazuli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[application] | ||
name = TablePlus | ||
|
||
[configuration_files] | ||
Library/Application Support/com.tinyapp.TablePlus | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You also need |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is gonna work, it's specific to each computer no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. These paths are documented in the Cyberduck wiki page.
https://trac.cyberduck.io/wiki/help/en/faq#Preferencesandapplicationsupportfileslocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. Did you test the config yourself? e.g.
mackup backup
followed bymackup uninstall
andmackup restore
?I suggest splitting those 2 apps in 2 PR so we can merge the easy one and dig into the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The
mackup backup
command works fine. i have it in my personal.mackup
config folder. But i haven't tried running theuninstall
andrestore
command.But i just noticed the path in line 7 doesn't exists. If i'm not mistaken, that was for an older version of Cyberduck.
But sure. i will try to split those PR a bit later. sorry for the trouble.