Add CI check for Bun runtime #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed requests (and more)
PetrHeinz
force-pushed
the
ph/test-bun-runtime
branch
from
712317e
to
687290a
Compare
|
It would be nice to see which runtime/version was used in Better Stack (e.g. |
|
Beautiful 🙂 
|
gyfis
approved these changes
Sep 20, 2023
gyfis
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting Bun in our test pipeline would be a bit hard, even if we'd skip some irrelevant use cases (particularly Browser). Mocking requests via
nockdoesn't seem to work properly and there are some other failures because of the testing environment.If we wanted to go that way, I'd recommend having a configurable
fetchcallback in options that we could rewrite with our own mocked method. This should allow us to dropnockcompletely.I tested our
example-projectin Bun and it was buildable and worked out of the box. Added end-to-end tests for all supported environments (Node and Bun).Created a new source E2E test for logtail/logtail-js and added it's source token into repository secrets.
E2E tests cannot be meaningfully run on branches, since they're downloading released
@logtail/*dependencies. For this reason I've opted for running it onmasterpushes, every Monday at 5:20 am, and possibly manually.WDYT?