Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starters: 0.12.0 updates (remove notes, devcontainer, prefix + more) #846

Merged
merged 11 commits into from
Oct 28, 2024

Conversation

jondot
Copy link
Contributor

@jondot jondot commented Oct 14, 2024

@jondot
Copy link
Contributor Author

jondot commented Oct 15, 2024

fixes #820

@darricheng
Copy link
Contributor

@jondot Looking at the changes, it looks like you are completely changing the saas starter template to be a clean template instead. I'm wondering if there is value in creating two saas templates:

  • Demo app similar to the existing one
  • Skeleton project which is the demo app without the example routes (which in this case is notes)

This way, we can serve both new users who want something to explore as well as existing users who just need a plain skeleton to start. One example of an existing well-known framework that has both options like so is SvelteKit:

Screenshot 2024-10-19 at 11 26 12 AM

@ephbaum
Copy link

ephbaum commented Oct 23, 2024

question: why remove the containers?

@jondot
Copy link
Contributor Author

jondot commented Oct 23, 2024

@ephbaum we've gotten feedback that sometimes (because of how VSCode works) a pop up jumps in, people click "accept" and then a container workflow starts and from there confusion starts. we're going to introduce this back as a loco g deployment and name it something like vscode-devcontainers and not have it by default.

@darricheng we've gotten requests to remove the "boilerplate" because as people adopt Loco, they anyways start cleaning that up. That, combined with the ability to generate full scaffold now, makes the sample notes obsolete. You can now generate it back with cargo loco g scaffold .... That said -- the Svelte example you show is very cool. We have a todo app we can use (its in loco-org) for that somehow.

@darricheng
Copy link
Contributor

@jondot I think what you said makes a lot of sense. A full-featured example like a working todo app would definitely be much better for the desired outcome of letting users explore a working app than just having a skeleton with a notes scaffold added to it.

@ephbaum
Copy link

ephbaum commented Oct 23, 2024

Thanks for the reply @jondot, that makes sense

I asked because this is one of the few projects where the devcontainer configuration actually works pretty well from the start and didn't want to see it removed entirely

My only (devcontainer) complaint from toying with the SaaS starter is not having node available by default - in my case I simply installed node via asdf through the Dockerfile into the app container though I could see a node container for building as well and thought about opening an issue to discuss

I've found some bugs and behavioral quirks (such as the bad links in the welcome email for at least the saas starter) but overall I see a lot of potential for Loco and I'm excited to see where it goes from here.

Thanks again for taking the time to reply, I appreciate it 🙏

@jondot jondot changed the title saas: remove notes, devcontainer starters: 0.12.0 updates (remove notes, devcontainer, prefix + more) Oct 27, 2024
@chamons
Copy link

chamons commented Oct 28, 2024

Just checking out loco for a side project and I ran into this PR and wanted to note my approval.

The first thing I did was start ripping out the notes model.

@jondot
Copy link
Contributor Author

jondot commented Oct 28, 2024

devcontainer now here: https://github.com/loco-rs/loco-devcontainer

@jondot jondot closed this Oct 28, 2024
@jondot jondot reopened this Oct 28, 2024
@jondot jondot merged commit f4fbc7c into master Oct 28, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants