Skip to content

Commit

Permalink
Do not set XLA_TARGET when using Livebook CUDA-based images (#2755)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonatanklosko committed Aug 19, 2024
1 parent 1ac585c commit fbb387e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
6 changes: 1 addition & 5 deletions lib/livebook/config.ex
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,7 @@ defmodule Livebook.Config do

[
%{tag: version, name: "Livebook", env: []},
%{
tag: "#{version}-cuda12",
name: "Livebook + CUDA 12",
env: [{"XLA_TARGET", "cuda120"}]
}
%{tag: "#{version}-cuda12", name: "Livebook + CUDA 12", env: []}
]
end

Expand Down
5 changes: 1 addition & 4 deletions test/livebook/hubs/dockerfile_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ defmodule Livebook.Hubs.DockerfileTest do

assert dockerfile =~ """
FROM ghcr.io/livebook-dev/livebook:#{@version}-cuda12
ENV XLA_TARGET "cuda120"
"""
end

Expand Down Expand Up @@ -251,10 +249,9 @@ defmodule Livebook.Hubs.DockerfileTest do
hub = team_hub()
agent_key = Livebook.Factory.build(:agent_key)

%{image: image, env: env} = Dockerfile.online_docker_info(config, hub, agent_key)
%{image: image, env: _env} = Dockerfile.online_docker_info(config, hub, agent_key)

assert image == "ghcr.io/livebook-dev/livebook:#{@version}-cuda12"
assert {"XLA_TARGET", "cuda120"} in env
end

test "deploying with auto cluster setup" do
Expand Down

0 comments on commit fbb387e

Please sign in to comment.