Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for network-policies for self-agent and control-plane in helmchart #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jonsy13
Copy link
Contributor

@Jonsy13 Jonsy13 commented Jun 21, 2022

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Vedant Shrotria <[email protected]>
Signed-off-by: Vedant Shrotria <[email protected]>
Copy link
Member

@Jasstkn Jasstkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey.

Seems good for me but you must bump chart version and perform docs update. I would also suggest to make some note in the values.yaml that those policies will be effective only if the CNI in the cluster supports it.

@Jasstkn Jasstkn added the status/awaiting-contributor Use to mark PR label Jun 25, 2022
@Jasstkn
Copy link
Member

Jasstkn commented Oct 26, 2022

@Jonsy13 hey. will you continue working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants