release.sh: update to take a --token value #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the old way no longer works, so let's update with a copy/paste from the examples. Intentional switch to use --token because that's how you should be doing releases anyway - with a temporary token that can be revoked after the release is complete (and that also encodes the username). https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release
|
Note to self: the wiki page needs updating after merging this |
I assume the release.sh for input-wacom should be updated to keep all linuxwacom projects in-sync. What about libwacom? Are you using a better approach for libwacom? Should we adapt the other two projects to libwacom instead? |
|
libwacom has always used this release.sh anyway, so there's no need to sync here. |
|
Thank you. Sounds good to me. Feel free to merge the patch. We'll update release.sh for input-wacom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the old way no longer works, so let's update with a copy/paste from the examples.
Intentional switch to use --token because that's how you should be doing releases anyway - with a temporary token that can be revoked after the release is complete (and that also encodes the username).
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release