Revert "wcmUSB: Correct bounds check of maximum button number"

This fixed the wrong issue, the undefined behavior was caused by
(1 << btn) defaulting to int rather than unsigned int. See the follow-up
commit for a fix.

This reverts commit bf61b3e.

src/wcmUSB.c

@@ -1361,7 +1361,7 @@ mod_buttons(WacomCommonPtr common, unsigned int buttons, unsigned int btn, Bool
 {
 	unsigned int mask;
 
-	if (btn >= sizeof(int) * 8 - 1)
+	if (btn >= sizeof(int) * 8)
 	{
 		wcmLogCommonSafe(common, W_ERROR,
 		       "%s: Invalid button number %u. Insufficient storage\n",
@@ -2085,15 +2085,14 @@ static int usbProbeKeys(WacomDevicePtr priv)
 TEST_CASE(test_mod_buttons)
 {
 	WacomCommonRec common = {0};
-	for (size_t i = 0; i < sizeof(int) * 8 - 1; i++)
+	for (size_t i = 0; i < sizeof(int) * 8; i++)
 	{
 		unsigned int buttons = mod_buttons(&common, 0, i, 1);
 		assert(buttons == (1u << i));
 		buttons = mod_buttons(&common, 0, i, 0);
 		assert(buttons == 0);
 	}
 
-	assert(mod_buttons(&common, 0, sizeof(int) * 8 - 1, 1) == 0);
 	assert(mod_buttons(&common, 0, sizeof(int) * 8, 1) == 0);
 }