Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to noble #184

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Rebase to noble #184

merged 2 commits into from
Aug 20, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented Aug 19, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team August 19, 2024 17:52
@thespad thespad self-assigned this Aug 19, 2024
github-actions[bot]
github-actions bot reviewed Aug 19, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-67c3c01d-dev-3b59cd4197e1bf0411570c2a8d67313c2d1f2c5a-pr-184/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-67c3c01d-dev-3b59cd4197e1bf0411570c2a8d67313c2d1f2c5a-pr-184/shellcheck-result.xml

Tag Passed
amd64-4.91.1-pkg-67c3c01d-dev-3b59cd4197e1bf0411570c2a8d67313c2d1f2c5a-pr-184 ✅
arm64v8-4.91.1-pkg-67c3c01d-dev-3b59cd4197e1bf0411570c2a8d67313c2d1f2c5a-pr-184 ✅

aptalca
aptalca reviewed Aug 19, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@thespad thespad requested a review from aptalca August 19, 2024 19:32
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-67c3c01d-dev-f6e7d4e563ed2d01dfcbceacbd14a452f0ea4a18-pr-184/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-67c3c01d-dev-f6e7d4e563ed2d01dfcbceacbd14a452f0ea4a18-pr-184/shellcheck-result.xml

Tag Passed
amd64-4.91.1-pkg-67c3c01d-dev-f6e7d4e563ed2d01dfcbceacbd14a452f0ea4a18-pr-184 ✅
arm64v8-4.91.1-pkg-67c3c01d-dev-f6e7d4e563ed2d01dfcbceacbd14a452f0ea4a18-pr-184 ✅

@thespad thespad merged commit 11dbec9 into master Aug 20, 2024
6 checks passed
@thespad thespad deleted the master-noble branch August 20, 2024 15:08
@calvin-li-developer
Copy link

Can close #180, as a result of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@aptalca aptalca aptalca approved these changes

Assignees

@thespad thespad

Labels
None yet
Projects
Issue & PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thespad @LinuxServer-CI @calvin-li-developer @aptalca