-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git-lfs support #181
base: master
Are you sure you want to change the base?
Add git-lfs support #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
Not sure how I can make this PR move to "ready for review" stage on the project board. I have completed all the tasks. |
Thanks for the PR, but. . .
It's not a tiny package.
Our I asked the team members and while many of them use code-server, none of them use LFS, so I'd question how common it is. I fail to see why it shouldn't be installed with our universal package install mod. Our code-server image is fairly barebones and it only includes the required packages. Anything else is installed via mods. |
Installing it on top of the existing image is inferior since the writes are not merged into one of the existing layers. But if you do not believe this is widely used then I can continue adding it on top of the existing image, and you can close this PR. Thanks for checking! |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Description:
Adds the git-lfs apt package to enable support for Git Large File Storage.
Benefits of this PR and context:
Git LFS is widely used for repos that contain binary files. As the Code-Server is often used with git, it makes for this small package to be included in order to have this functionality
My personal use case is using the
code-server
instance to edit the repo containing my Obsidian notes vault, where LFS is used to store the attachments.Even this repository is enabled for LFS as there is a
.gitattributes
file, so this use case is quite common, and IMHO it's worth including this in the base image as opposed to as an add-on via Docker Mods.How Has This Been Tested?
Tested that the package install from apt succeeded and git-lfs extensions were available.
Final testing will occur using LinuxServer CI.
Source / References:
Git Large File Storage
https://github.com/linuxserver/docker-code-server/blob/master/.gitattributes