Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-lfs support #181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

geekifier
Copy link

@geekifier geekifier commented Jun 1, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Adds the git-lfs apt package to enable support for Git Large File Storage.

Benefits of this PR and context:

Git LFS is widely used for repos that contain binary files. As the Code-Server is often used with git, it makes for this small package to be included in order to have this functionality

My personal use case is using the code-server instance to edit the repo containing my Obsidian notes vault, where LFS is used to store the attachments.

Even this repository is enabled for LFS as there is a .gitattributes file, so this use case is quite common, and IMHO it's worth including this in the base image as opposed to as an add-on via Docker Mods.

How Has This Been Tested?

Tested that the package install from apt succeeded and git-lfs extensions were available.
Final testing will occur using LinuxServer CI.

Source / References:

Git Large File Storage
https://github.com/linuxserver/docker-code-server/blob/master/.gitattributes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.89.1-pkg-2e2dbd2e-dev-1548f08cf2e0192f0f9e0030fbbce7f5f5d4a939-pr-181/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.89.1-pkg-2e2dbd2e-dev-1548f08cf2e0192f0f9e0030fbbce7f5f5d4a939-pr-181/shellcheck-result.xml

Tag Passed
amd64-4.89.1-pkg-2e2dbd2e-dev-1548f08cf2e0192f0f9e0030fbbce7f5f5d4a939-pr-181
arm64v8-4.89.1-pkg-2e2dbd2e-dev-1548f08cf2e0192f0f9e0030fbbce7f5f5d4a939-pr-181

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.90.2-pkg-ec2f2738-dev-7cc100bf3cecda5485363f30a24ae692e2428cae-pr-181/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.90.2-pkg-ec2f2738-dev-7cc100bf3cecda5485363f30a24ae692e2428cae-pr-181/shellcheck-result.xml

Tag Passed
amd64-4.90.2-pkg-ec2f2738-dev-7cc100bf3cecda5485363f30a24ae692e2428cae-pr-181
arm64v8-4.90.2-pkg-ec2f2738-dev-7cc100bf3cecda5485363f30a24ae692e2428cae-pr-181

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.0-pkg-a6b2b800-dev-e6189835c306b2f0b8960d320a185e5b39c80ca3-pr-181/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.0-pkg-a6b2b800-dev-e6189835c306b2f0b8960d320a185e5b39c80ca3-pr-181/shellcheck-result.xml

Tag Passed
amd64-4.91.0-pkg-a6b2b800-dev-e6189835c306b2f0b8960d320a185e5b39c80ca3-pr-181
arm64v8-4.91.0-pkg-a6b2b800-dev-e6189835c306b2f0b8960d320a185e5b39c80ca3-pr-181

@geekifier geekifier changed the title Feature/git lfs Add git-lfs support Jul 29, 2024
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-656d23d7-dev-1a04dec03f25ff1161b6b1b2cad44a5be561fd20-pr-181/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-656d23d7-dev-1a04dec03f25ff1161b6b1b2cad44a5be561fd20-pr-181/shellcheck-result.xml

Tag Passed
amd64-4.91.1-pkg-656d23d7-dev-1a04dec03f25ff1161b6b1b2cad44a5be561fd20-pr-181
arm64v8-4.91.1-pkg-656d23d7-dev-1a04dec03f25ff1161b6b1b2cad44a5be561fd20-pr-181

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-ab8f4cb9-dev-449ecb74f6f812eabdde7a86eb535af13503dd3c-pr-181/index.html
https://ci-tests.linuxserver.io/lspipepr/code-server/4.91.1-pkg-ab8f4cb9-dev-449ecb74f6f812eabdde7a86eb535af13503dd3c-pr-181/shellcheck-result.xml

Tag Passed
amd64-4.91.1-pkg-ab8f4cb9-dev-449ecb74f6f812eabdde7a86eb535af13503dd3c-pr-181
arm64v8-4.91.1-pkg-ab8f4cb9-dev-449ecb74f6f812eabdde7a86eb535af13503dd3c-pr-181

@geekifier
Copy link
Author

Not sure how I can make this PR move to "ready for review" stage on the project board. I have completed all the tasks.

@aptalca
Copy link
Member

aptalca commented Aug 19, 2024

Thanks for the PR, but. . .

After this operation, 10.4 MB of additional disk space will be used.

It's not a tiny package.

Even this repository is enabled for LFS as there is a .gitattributes file, so this use case is quite common, and IMHO it's worth including this in the base image as opposed to as an add-on via Docker Mods.

Our .gitattributes is a fairly generic one that tries to encompass as many scenarios as possible as it has no downside of including more.

I asked the team members and while many of them use code-server, none of them use LFS, so I'd question how common it is. I fail to see why it shouldn't be installed with our universal package install mod. Our code-server image is fairly barebones and it only includes the required packages. Anything else is installed via mods.

@geekifier
Copy link
Author

I asked the team members and while many of them use code-server, none of them use LFS, so I'd question how common it is. I fail to see why it shouldn't be installed with our universal package install mod. Our code-server image is fairly barebones and it only includes the required packages. Anything else is installed via mods.

Installing it on top of the existing image is inferior since the writes are not merged into one of the existing layers. But if you do not believe this is widely used then I can continue adding it on top of the existing image, and you can close this PR. Thanks for checking!

@LinuxServer-CI
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants