Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for EL10 #166

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Commits on Jul 1, 2024

  1. fix: add support for EL10

    According to the Ansible team, support for listing platforms in
    role `meta/main.yml` files is being removed.
    Instead, they recommend using `galaxy_tags`
    
    https://github.com/ansible/ansible/blob/stable-2.17/changelogs/CHANGELOG-v2.17.rst
    "Remove the galaxy_info field platforms from the role templates"
    ansible/ansible#82453
    
    Many roles already have tags such as "rhel", "redhat", "centos", and "fedora".
    I propose that we ensure all of the system roles have these tags.
    Some of our roles support Suse, Debian, Ubuntu, and others.
    We should add tags for those e.g. the ssh role already has tags for "debian" and "ubuntu".
    
    In addition - for each version listed under `platforms.EL` - add a tag like `elN`.
    
    Q: Why not use a delimiter between the platform and the version e.g. `el-10`?
    
    This is not allowed by ansible-lint:
    
    ```
    meta-no-tags: Tags must contain lowercase letters and digits only., invalid: 'el-10'
    meta/main.yml:1
    ```
    
    So we cannot use uppercase letters either.
    
    Q: Why not use our own meta/main.yml field?
    
    No other fields are allowed by ansible-lint:
    
    ```
    syntax-check[specific]: 'myfield' is not a valid attribute for a RoleMetadata
    ```
    
    Q: Why not use some other field?
    
    There are no other applicable or suitable fields.
    
    Q: What happens when we want to support versions like `N.M`?
    
    Use the word "dot" instead of "." e.g. `el10dot3`.
    Similarly - use "dash" instead of "-".
    
    We do not need tags such as `fedoraall`.
    The `fedora` tag implies that the role works on all supported versions of fedora.
    Otherwise, use tags such as `fedora40` if the role only supports specific versions.
    
    In addition - for roles that have different variable files for EL9, create
    the corresponding EL10 files.
    
    Signed-off-by: Rich Megginson <[email protected]>
    richm committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5d605e8 View commit details
    Browse the repository at this point in the history