Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step in addressing the numerous issues I have seen in the repo with users encountering unexpected errors during firmware updates, such as #37, #35, and others. I outlined my plan to address this in #39, and this PR implements it.
The end result will be a repo that is much easier to safely add new features to, such as support for new boards (like the ESP32 PR), and more friendly to users and maintainers.
NOTE:
Before merging this PR, @grassjelly please rename the current default branch, currently named "
galactic
" tomaster
(this is in accordance with the naming ofros_control
and other ROS things I looked at ) or let me know if you'd prefermain
orrolling
and I'll modify the PR. The reasons for this request is two-fold:galactic
"galactic
branch name should be available for backports to ROS2 GalacticIf this renaming is not made, this PR will behave slightly silly upon merge, (but still largely work and still be an improvement):
master
will not be validgalactic
androlling
actions will be run on the current default branch, "galactic
", and thegalactic
action will fail, as the "galactic
" branch'sfirmware/platformio.ini
has a library dependency that has deprecated galacticNOTE 2:
There will be companion PRs to the
humble
andfoxy
branches. These should all be merged at a similar time to allow the actions to work for those branches. The foxy PR also contains fixes to current deprecation issues. Upon renaming of the current "galactic
" branch to something else, I will also create a PR for it.