-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] chore: update to v0.3.1 #29
Conversation
@nicoburns for awareness, as the release was requested by them. |
I've backed this out because of the PR description - making commits which mention people has occasionally backfired, because GitHub likes pinging that user when people make forks/do merges incorrectly, etc. I've had that a few times in Bevy, and so want to avoid that here. (I also don't think that we should include the full changelog in the PR description anyway, because those changes aren't actually in this PR) I'd suggest changing the description to just something like: Fix the changelog format of previous releases.
Release version 0.3.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also add the equivalent paragraph to https://github.com/linebender/vello/blob/main/CHANGELOG.md#changelog here (i.e. the latest published Vello SVG release is ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
And please fix the changelog in a separate PR from doing the release. |
Yeah, my bad. I didn't realize the merge queue takes the description and uses it as a commit message. I'll take a mental note of that in the future. |
Done, that's now #30 |
Not approving until #30 lands and is merged with this. |
Co-authored-by: Daniel McNab <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix the changelog format of previous releases.
Release version 0.3.1.