New "style" encoding to replace "linewidth" #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armansito
force-pushed
the
gpu-stroke-rework
branch
from
84c0ef7
to
d2715d2
Compare
dfrg
approved these changes
Oct 25, 2023
crates/encoding/src/path.rs
Outdated
| /// ``` | ||
| /// | ||
| /// - miter_limit: u16 - The miter limit for a stroke, encoded in binary16 (half) floating | ||
| /// point representation. This field is on meaningful for the `Join::Miter` |
crates/encoding/src/path.rs
Outdated
| pub const FLAGS_END_CAP_MASK: u32 = 0x0300_0000; | ||
| pub const MITER_LIMIT_MASK: u32 = 0xFFFF; | ||
|
|
||
| pub fn from_fill(fill: &Fill) -> Self { |
There was a problem hiding this comment.
I think it’d be slightly cleaner to take this parameter by value.
crates/encoding/src/path.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| fn get_fill(&self) -> Option<Fill> { |
There was a problem hiding this comment.
Small style nit: I know these are only for tests now but it seems likely they’ll become generally useful enough to be exposed at some point and the get_ prefix is generally elided for accessors.
This will be used to pack the f64 miter_limit field in `kurbo::Stroke` into a 16-bit encoding for GPU consumption.
Style encodes stroke vs fill style and their related parameters in an 8-byte data structure as described in vello#303. This data structure will replace the existing "linewidth" stream.
Added a test scene specifically for fill rules, drawing a star shape and intersecting arcs with opposite winding.
* The linewidth stream is now the "style" stream. This has been wired up all the way up to the `flatten` pipeline which uses the new encoding to extract the fill rule. * Pipelines downstream of `flatten` still use the old linewidth scheme. They will be fixed up in a follow-up change.
armansito
force-pushed
the
gpu-stroke-rework
branch
from
d2715d2
to
a6b3f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the existing floating-point "linewidth" stream with a new "style" stream based on the proposal in #303.
flattenhave been wired up to extract the fill style using the new encoding.