Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of extern crate syntax. #351

Merged

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@RickyDaMa
Copy link
Collaborator

Would this also mean that we can remove this dependency from the Cargo.toml?

serde_repr = "0.1"

Thanks for your continual efforts to modernise the repo; is there a particular motivation behind this PR beyond just bringing norad more up-to-date?

@waywardmonkeys
Copy link
Contributor Author

Would this also mean that we can remove this dependency from the Cargo.toml?

No ... that's what makes it available for use. Just that since Rust 2018 edition, the extern crate is no longer needed, just having it in the Cargo.toml is enough.

Thanks for your continual efforts to modernise the repo; is there a particular motivation behind this PR beyond just bringing norad more up-to-date?

Sadly, no! I just help out on a bunch of the linebender repos and this is in the linebender organization!

I don't even know what UFO files are (beyond what the readme says).

@RickyDaMa
Copy link
Collaborator

Would this also mean that we can remove this dependency from the Cargo.toml?

No ... that's what makes it available for use.

My bad, I completely missed the usages of serde_repr's macros in the source code, I thought it might have been an unused dependency

Thanks for your time!

@RickyDaMa RickyDaMa merged commit 22156ea into linebender:master Jul 22, 2024
4 checks passed
@waywardmonkeys waywardmonkeys deleted the remove-extern-crate-usages branch July 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants