Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.12.0 #319

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Bump version to 0.12.0 #319

merged 1 commit into from
Aug 23, 2023

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Aug 22, 2023

No description provided.

@RickyDaMa
Copy link
Collaborator

Because we're not at a major release yet and we're only adding new API, could we just make this a patch version? Or are you considering that the behaviour of DesignSpaceDocument::save has changed because it now writes additional fields, and thus this is breaking?

@cmyr
Copy link
Member Author

cmyr commented Aug 23, 2023

Adding new fields to a struct where all fields are public is a breaking change, because you might have previously had code that either created a new struct or destructured an existing one, which will no longer compile. :(

Copy link
Collaborator

@RickyDaMa RickyDaMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, well made. I'm glad there are Cargo tools that try and automate this sort of thing, because it's nightmare-ish for mere mortals like myself 🤯

@cmyr cmyr merged commit b142add into master Aug 23, 2023
4 checks passed
@cmyr cmyr deleted the bump-version branch August 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants