Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP POST Request functionality added #11

Closed
wants to merge 25 commits into from
Closed

HTTP POST Request functionality added #11

wants to merge 25 commits into from

Conversation

S0S4
Copy link
Collaborator

@S0S4 S0S4 commented Sep 4, 2024

We can use http_post() for sending HTTP POST requests to the server.

lucabtz and others added 24 commits September 3, 2024 20:27
@lucabtz
Removed HTTP related code from main.c
d6affe3
@lucabtz
Added simple HTTP GET functionality
49ab3dd
@lucabtz
Freeing properly the HTTP response object
ca6c473
@lucabtz
Implement cleanup
3d1a183
@lucabtz
Merge branch 'main' into implement-http-download
6a2eb88
@S0S4
Merge remote-tracking branch 'upstream/http-download' into http-download
ef7260a
@lucabtz
Use keep-alive connections
4a4f342
@lil-skelly
Merge pull request lil-skelly#9 from S0S4/http-download
7a14810 
[SOLVED] Fixed the problem with chunk path
Merge branch 'main' of https://github.com/lil-skelly/erebos into http…
1ebfbda 
…-download

Keep branch up to date with main to include crucial changes
Minor changes: Removed unused code
6c51a68
Removed example code and used the http_get function to request the in…
46c258d 
…dex page of the server
Merge branch 'http-download' of https://github.com/lil-skelly/erebos …
06941b1 
…into http-download
Modified server.py to use self.server.server_address to successfully …
b0563ab 
…generate the index links
@lil-skelly
Merge pull request lil-skelly#10 from ekardnam/implement-http-download
122f94d 
Fix server not generating links properly (missing host) and moved definitions from http.c to http.h
Added h_getnameinfo wrapper to fetch host name. Removed annoying debu…
3c9629d 
…g statement from http.c and used long instead of size_t for the content lengths
Merge branch 'http-download' of https://github.com/lil-skelly/erebos …
ac9def0 
…into http-download

Update local branch
Merge branch 'main' of https://github.com/lil-skelly/erebos into http…
d880428 
…-download
Modified http.c
6c3e4d7
Merge branch 'main' of https://github.com/lil-skelly/erebos into http…
dec36a3 
…-download
Merge branch 'main' of https://github.com/lil-skelly/erebos into http…
c8d0f7f 
…-download
Modified client to now send the Host header with the host name of the…
2408066 
… server and now the server uses that header to generate the file links
Revert "Modified client to now send the Host header with the host nam…
66899c3 
…e of the server and now the server uses that header to generate the file links"

While the approach works it introduces unneeded difficulties. Let's just go with the simpler approach
This reverts commit 2408066.
Implemented http_download_data_to_file, added request field to the ht…
c360265 
…tp_res_t and used a different buffer to store the GET request. Finally added some basic logging in the http library,
@S0S4
[WIP] HTTP Post Request function done
c6cd536
lil-skelly
lil-skelly requested changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@lil-skelly lil-skelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reworked to be compliant with the current structure, the POST function should parse the response to a http_res_t structure similarly to the http_get function. For logging use the already existing print_http_res function.

@lil-skelly lil-skelly closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lil-skelly lil-skelly lil-skelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S0S4 @lil-skelly @lucabtz