Fix/fix adding dataset to groups #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper converts a value into a form that can be used as a sort key - for example, it converts a group's display_name so that a list of groups can be sorted by display_name. Our group titles are multilingual, so we need to localise the value before this can be done.
bellisk
force-pushed
the
fix/fix-adding-dataset-to-groups
branch
from
9a256ca
to
266caa2
Compare
When we try to get toolkit.request.environ while rebuilding the search index, we get a RuntimeError, 'Working outside of request context,' so we need to catch that here as well as the TypeError.
bellisk
force-pushed
the
fix/fix-adding-dataset-to-groups
branch
from
f887786
to
32dfb80
Compare
bellisk
commented
Nov 14, 2024
| @@ -61,7 +61,7 @@ jobs: | |||
| - name: Create ckan container | |||
| run: | | |||
| /usr/bin/docker create --name test_ckan --network ${{ job.container.network }} --network-alias ckan \ | |||
| --env-file ${{ github.workspace }}/github-workflow.env \ | |||
| --env-file ${{ github.workspace }}/github-workflow.env --user root \ | |||
There was a problem hiding this comment.
This is needed so that tests run on the new, root-user-minimised CKAN docker container.
See this comment by Adrià for details: ckan/ckan-docker-base#86 (comment).
bellisk
force-pushed
the
fix/fix-adding-dataset-to-groups
branch
from
bd66b01
to
0011d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.