Lpd 35068 4 #6082
Open
Lpd 35068 4 #6082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# breaking ## What modules/apps/style-book/style-book-service/service.xml Added themeId and themeName to modules/apps/style-book/style-book-service/service.xml ## Why To allow the user to choose a token definition for a new Style Book to be based on. These changes were added and the bundle version was updated by buildService in style-book-api/bnd.bnd. ----
# breaking ## What modules/apps/style-book/style-book-service/src/main/java/com/liferay/style/book/internal/upgrade/registry/StyleBookServiceUpgradeStepRegistrator.java Added themeId and themeName to StyleBookServiceUgpradeStepRegistrator.java ## Why CI failed a previous commit because the added themeId and themeName columns could not be found after an upgrade was performed, so these columns were added to the database here. I ran foratSource and baseline in modules/apps/style-book and style-book-service/bnd.bnd was updated. ----
…t's already add it in the 'add' methods
…e. Otherwise new databases will differ from upgraded ones
thiago-buarqque
force-pushed
the
LPD-35068-4
branch
from
7873ad3
to
b3fe310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.