Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync SR1.5 branch with the latest develop #858

Draft
wants to merge 663 commits into
base: feat/sr-1.5
Choose a base branch
from

Conversation

tamtamchik
Copy link
Member

@tamtamchik tamtamchik commented Oct 11, 2024

Trying to make the update as smooth as possible 🫡

Restored CI actions, unit tests, and scratch deployment.

TODO:

  • fix integration tests on scratch (consider changes from SR1.5)
  • fix integration tests on the mainnet fork (add upgrade steps for applying changes from SR1.5 to protocol on the mainnet fork)
  • move /contracts/*/test_helpers/ to /test
    • rename based on __Mock / __Harness convention
    • format as other test contracts

Port of #216

tamtamchik and others added 30 commits August 27, 2024 12:05
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.7 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.7...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
TheDZhon and others added 9 commits October 10, 2024 21:17
backport: changes from master to develop
# Conflicts:
#	.github/workflows/analyse.yml
#	.github/workflows/assert-bytecode.yml
#	.github/workflows/fix-abi-pr.yml
#	.github/workflows/linters.yml
#	.github/workflows/release-abis.yml
#	.github/workflows/storage-layout-check.yml
#	.github/workflows/storage-layout-update.yml
#	.gitignore
#	README.md
#	accounts.sample.json
#	apps/lido/scripts/buidler-hooks.js
#	apps/lidooracle/scripts/buidler-hooks.js
#	apps/node-operators-registry/scripts/buidler-hooks.js
#	contracts/common/test_helpers/SignatureUtilsConsumer_0_4_24.sol
#	contracts/common/test_helpers/SignatureUtilsConsumer_0_8_9.sol
#	deployed-goerli.json
#	deployed-mainnet.json
#	deployed-sepolia.json
#	docs/scratch-deploy.md
#	gasprofile/gasprofile.js
#	hardhat.config.js
#	package.json
#	poetry.lock
#	pyproject.toml
#	scripts/constants.js
#	scripts/extract-artifacts.js
#	scripts/hardhat-tasks.js
#	scripts/helpers/assert.js
#	scripts/helpers/deploy.js
#	scripts/helpers/persisted-network-state.js
#	scripts/helpers/run-or-wrap-script.js
#	scripts/scratch/01-deploy-deposit-contract.js
#	scripts/scratch/05-obtain-deployed-instances.js
#	scripts/scratch/06-register-ens-domain.js
#	scripts/scratch/07-deploy-apm.js
#	scripts/scratch/08-obtain-deployed-apm.js
#	scripts/scratch/10-deploy-dao.js
#	scripts/scratch/12-issue-tokens.js
#	scripts/scratch/13-deploy-non-aragon-contracts.js
#	scripts/scratch/15-finalize-dao.js
#	scripts/scratch/16-initialize-non-aragon-contracts.js
#	scripts/scratch/20-check-dao.js
#	scripts/scratch/checks/apps.js
#	scripts/staking-router.js
#	scripts/upgrade/deploy-new-app-instance.js
#	scripts/upgrade/obtain-deployed-new-app-instance.js
#	scripts/upgrade/upgrade-app.js
#	scripts/upgrade/vote-new-oracle-impl.js
#	scripts/utils/verify-vote-tx.js
#	test/0.8.9/withdrawal-queue-share-rate-changes.test.js
#	test/common/math-256.test.sol
#	test/common/signature-utils.test.sol
#	test/helpers/config.js
#	test/helpers/factories.js
#	test/helpers/oracle.js
#	test/helpers/protocol.js
#	test/helpers/utils.js
#	test/scenario/lido-wq-acct-oracle-integration-gas.test.js
#	yarn.lock
# Conflicts:
#	README.md
#	deployed-mainnet.json
#	lib/deploy.ts
#	package.json
#	test/0.8.9/contracts/AccountingOracle__MockForSanityChecker.sol
@tamtamchik tamtamchik requested review from a team as code owners October 11, 2024 16:08
@tamtamchik tamtamchik marked this pull request as draft October 11, 2024 16:08
@tamtamchik tamtamchik changed the base branch from master to develop October 11, 2024 16:09
@tamtamchik tamtamchik changed the title chore: update SR1.5 dev branch with latest changes from develop branch chore: Sync SR1.5 branch with the latest develop Oct 11, 2024
@tamtamchik tamtamchik changed the base branch from develop to feat/sr-1.5 November 7, 2024 06:57
Copy link

github-actions bot commented Nov 7, 2024

badge

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ---------
contracts/0.4.24/Lido.sol                                        212       0  100.00%
contracts/0.4.24/StETH.sol                                        72       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        71       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   18       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22       0  100.00%
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   189-190
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      232       0  100.00%
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3016     118  96.09%

Diff against master

Filename                                                       Stmts    Miss  Cover
-----------------------------------------------------------  -------  ------  --------
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   +27       0  +100.00%
contracts/0.8.9/DepositSecurityModule.sol                        +24       0  +100.00%
contracts/0.8.9/StakingRouter.sol                                +13       0  +100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      +19      +1  -0.47%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      +61       0  +100.00%
TOTAL                                                           +144      +1  +0.16%

Results for commit: 2518c9f

Minimum allowed coverage is 95%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants