Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Lido v2 fix comments #779

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

chore: Lido v2 fix comments #779

wants to merge 14 commits into from

Conversation

folkyatina
Copy link
Member

Aggregate contract comment fixes related to v2 here

@folkyatina
Don't capitalize Ether
7f69a03 
"ether" is not  capitalized on ethereum.org, so we should not too
@folkyatina folkyatina changed the base branch from master to develop June 27, 2023 08:20
@folkyatina folkyatina requested a review from TheDZhon June 27, 2023 08:25
TheDZhon
TheDZhon reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Like it

Left some suggestions.

Worth discussing the general approach regarding re-deployments here.

README.md Outdated Show resolved Hide resolved
contracts/0.4.24/StETH.sol Show resolved Hide resolved
contracts/0.4.24/StETH.sol Outdated Show resolved Hide resolved
contracts/0.4.24/StETH.sol Outdated Show resolved Hide resolved
contracts/0.4.24/StETH.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is good though a bit of chores would be nice to have 🙏

contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
Itzyboo1
Itzyboo1 reviewed Sep 12, 2023
View reviewed changes
Copy link

@Itzyboo1 Itzyboo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think
It looks better

@mymphe
Copy link
Contributor

mymphe commented Sep 4, 2024

Leaving this PR open as a reminder for the next upgrade but the repo is no longer maintained. LidoFinance protocol moved to core repository.

@tamtamchik tamtamchik changed the title Lido v2 fix comments chore: Lido v2 fix comments Oct 11, 2024
@TheDZhon TheDZhon added the next-upgrade Things to pickup for the next protocol upgrade label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itzyboo1 Itzyboo1 Itzyboo1 left review comments

@TheDZhon TheDZhon Awaiting requested review from TheDZhon

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@folkyatina @mymphe @TheDZhon @Itzyboo1 @avsetsin @tamtamchik