Implement /tv/{channel}/feed
endpoint
#78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the /tv/{channel}/feed endpoint and adds TypeDicts.
NOTE:
I attempted to add a test for this (test_tv.py) but for some reason vcrpy hangs during
make test_record
when hitting the test (possibly because this is a stream endpoint?). In the linked test, I clipped the stream at the first two results as this endpoint is an infinite stream.Interestingly enough, if you remove
@pytest.mark.vcr
the test passes, but we want this as a cassette. I was able to manually create a cassette for this (TestTV.test_stream_bullet_tv.yaml) which works, but would be problematic if the cassette needs to be regenerated so I assume this isn't something we want to manually add. vcrpy is new to me, so if anyone has an idea on what the issue might be please let me know and I'll gladly add a test for this.Checklist when adding a new endpoint
README.md
client.users.get_user()
, Correct:client.users.get()
berserk/types/
, exampleCHANGELOG.md
in theTo be released
section (to be created if necessary)