Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to reproduce the #266 issue with Google Drive + Gnome but I couldn't find any relevant
seek()
that would break it within theconstruct
library nor any file from thegvfs
behaved strangely. If anything, the issue might need a better traceback becauseself.build_stream(...)
calls further and it's still Python, so it shouldn't stop somewhere in the middle of the call stack if it's able to produce anOSError
.While the #266 isn't strictly a PyKeePass issue (and it's not reproducible clearly), I think leaving a free hand for the package to break the DB isn't really useful either. On top of that, some special files on Linux are actually sockets which may also happen to be used, thus it also makes sense to allow output to a socket.
Closes #266