Ensure the machine-id operation is the last one #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must ensure the modified image doesn't have any content in /etc/machine-id file. This will then trigger the usual systemd-machine-id-setup during the first boot of the image, ensuring we'll get an as unique as possible ID. This is mandatory, since the tools are generating a machine-id at different stages, for instance in order to ensure packages are installing without any issue[1] Of course, if the operator wants to get an actual machine-id, they can just disable the "machine-id" operation. Note that it's enabled by default, so the issue is more about ordering than anything. [1] For instance here: https://github.com/rwmjones/guestfs-tools/blob/3a498512f58bc431db490e96cdb712b19389bda4/customize/customize_run.ml#L170-L188
|
Patch sort of looks reasonable, although running it after the --customize operations [edit: which have order 99] might be wrong since those operations might be needed to fix any earlier built-in operation. However I asked on the bug for a reproducer so I can understand the exact sequence of steps that is being done and what goes wrong, because without that I cannot really tell if the bug has been fixed or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must ensure the modified image doesn't have any content in
/etc/machine-id file. This will then trigger the usual
systemd-machine-id-setup during the first boot of the image, ensuring
we'll get an as unique as possible ID.
This is mandatory, since the tools are generating a machine-id at
different stages, for instance in order to ensure packages are
installing without any issue[1]
Of course, if the operator wants to get an actual machine-id, they can
just disable the "machine-id" operation. Note that it's enabled by
default, so the issue is more about ordering than anything.
[1] For instance here: https://github.com/rwmjones/guestfs-tools/blob/3a498512f58bc431db490e96cdb712b19389bda4/customize/customize_run.ml#L170-L188